[
https://issues.apache.org/jira/browse/GEODE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282113#comment-17282113
]
ASF GitHub Bot commented on GEODE-8605:
---------------------------------------
kirklund commented on a change in pull request #5630:
URL: https://github.com/apache/geode/pull/5630#discussion_r573327664
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/configuration/CacheConfig.java
##########
@@ -2612,7 +2612,8 @@ public void setOverflowDirectory(String value) {
@XmlAccessorType(XmlAccessType.FIELD)
@XmlType(name = "", propOrder = {"gatewayEventFilters",
"gatewayEventSubstitutionFilter",
"gatewayTransportFilters"})
- public static class GatewaySender {
+ public static class GatewaySender extends CacheElement {
Review comment:
You should create a new unit test even for inner-classes. Any class that
you make Serializable should also have to unit test coverage to ensure that
both seriallization and deserialization succeeds and results in a faithful
replica of the original object (shamelessly copied from Effective Java 3rd Ed.
Item 86). I recommend using org.apache.commons.lang3.SerializationUtils to
simplify the unit testing.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAttributes.java
##########
@@ -88,6 +88,20 @@
public boolean enforceThreadsConnectSameReceiver =
GatewaySender.DEFAULT_ENFORCE_THREADS_CONNECT_SAME_RECEIVER;
+ // Added due to "alter gateway-sender" command
+
+ public boolean modifyAlertThreshold = false;
Review comment:
public mutable fields are not good. I guess this class has other such
fields so I'll just skip over this class. If it was me, I'd completely rewrite
this class to get make all fields private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Alter some GW senders attributes in runtime
> -------------------------------------------
>
> Key: GEODE-8605
> URL: https://issues.apache.org/jira/browse/GEODE-8605
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh, wan
> Reporter: Mario Ivanac
> Assignee: Mario Ivanac
> Priority: Major
> Labels: needs-review, pull-request-available
>
> We would like to introduce new command "alter gateway-sender" which would
> update some parameters in runtime. For now parameters of interest are:
> * {color:#6a8759}alert-threshold{color}
> * {color:#6a8759}batch-size{color}
> * {color:#6a8759}batch-time-interval{color}
> * {color:#6a8759}group-transaction-events{color}
> * {color:#6a8759}gateway-event-filter{color}
> * {color:#6a8759}gateway-transport-filter{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
