[
https://issues.apache.org/jira/browse/GEODE-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278839#comment-17278839
]
ASF GitHub Bot commented on GEODE-8624:
---------------------------------------
jdeppe-pivotal merged pull request #5986:
URL: https://github.com/apache/geode/pull/5986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve INCRBYFLOAT accuracy for very large values
> --------------------------------------------------
>
> Key: GEODE-8624
> URL: https://issues.apache.org/jira/browse/GEODE-8624
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Currently native redis appears to be able to apply {{INCRBYFLOAT}} on values
> that are below the max of unsigned long long (18446744073709551615). However,
> since we're treating numbers as {{double}}s we can lose precision for very
> large values. For example:
> {noformat}
> set val 18446744073709551614
> incrbyfloat val 1{noformat}
> incorrectly returns {{18446744073709552000}}
> Native redis produces a correct result.
> We should consider switching to using {{BigInteger}} for all commands which
> perform calculations: {{INCR, INCR, INCRBYFLOAT, HINCRBY, HINCRBYFLOAT}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
