[ 
https://issues.apache.org/jira/browse/GEODE-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276651#comment-17276651
 ] 

ASF subversion and git services commented on GEODE-8897:
--------------------------------------------------------

Commit c537109603f66b04c6533f6c971b40e22113ec12 in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c537109 ]

GEODE-8897: Improve Redis INCRBYFLOAT output accuracy for very large values 
(#5980)

- Switch to using BigDecimal instead of double for increment value.
- Also mark INCRBYFLOAT as supported.
- Add concurrency tests.

> Improve Redis INCRBYFLOAT output accuracy for very large values
> ---------------------------------------------------------------
>
>                 Key: GEODE-8897
>                 URL: https://issues.apache.org/jira/browse/GEODE-8897
>             Project: Geode
>          Issue Type: Test
>          Components: redis
>            Reporter: Jens Deppe
>            Assignee: Jens Deppe
>            Priority: Major
>              Labels: pull-request-available
>
> Currently native redis appears to be able to apply INCRBYFLOAT on values that 
> are below the max of unsigned long long (18446744073709551615). However, 
> since we're treating numbers as \{{double}}s we can lose precision for very 
> large values. For example:
>  
>  {{set val 18446744073709551614
> incrbyfloat val 1}}
> incorrectly returns {{18446744073709552000}}
> Native redis produces a correct result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to