[
https://issues.apache.org/jira/browse/GEODE-8885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276627#comment-17276627
]
ASF GitHub Bot commented on GEODE-8885:
---------------------------------------
ringles commented on a change in pull request #5973:
URL: https://github.com/apache/geode/pull/5973#discussion_r568102972
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHashesIntegrationTest.java
##########
@@ -48,6 +50,7 @@
private Jedis jedis;
private Jedis jedis2;
private static int ITERATION_COUNT = 4000;
+ private static int NUM_ITERATIONS = 1000;
Review comment:
Having a constant named "ITERATION_COUNT" right next to a constant named
"NUM_ITERATIONS" feels weird. At least one of them should be renamed to be a
bit more specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis: test HINCRBY command
> ---------------------------
>
> Key: GEODE-8885
> URL: https://issues.apache.org/jira/browse/GEODE-8885
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Hale Bales
> Assignee: Hale Bales
> Priority: Major
> Labels: pull-request-available
>
> Write unit/integration tests that run against both Geode Redis and native
> Redis, and dunit tests which test multiple concurrent clients accessing
> different servers for the following command:
> HINCRBY
> A.C.
> Unit/integration tests for both Geode and native Redis passing
> DUNIT tests passing
> README/redis_api_for_geode.html.md.erb updated to make command "supported"
> or
> Stories in the backlog to fix the identified issues (with JIRA tickets)
> and problem tests ignored
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
