[ 
https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276025#comment-17276025
 ] 

ASF GitHub Bot commented on GEODE-8496:
---------------------------------------

onichols-pivotal edited a comment on pull request #5828:
URL: https://github.com/apache/geode/pull/5828#issuecomment-770501970


   @jinmei it looks like the test 
DistributedSystemMBeanIntegrationTest.queryAllUsingGfshDoesNotFormatDate was 
expecting Date objects to be serialized as POJOs (i.e. the test expects to see 
the internal serialized fields of a LocalDate object).  Jackson 2.12 no longer 
allows that.  I've updated the test to instead expect the new failure message.  
Is this an acceptable change in default behavior?
   
   Perhaps better would be to start including the jsr310 jar in the shipping 
product, instead of as test-runtime-only dependency, so that date formatting 
always displays *something* out-of-the-box?  LocalDate is a built-in type in 
JDK8 and the only reason Jackson breaks it out as a separate module is for JDK7 
compatibility of jackson-core.  But since Geode is minimum JDK8, perhaps it 
makes us look bad if we don't support standard JDK8 date/time types...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> bump dependencies for 1.14
> --------------------------
>
>                 Key: GEODE-8496
>                 URL: https://issues.apache.org/jira/browse/GEODE-8496
>             Project: Geode
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen Nichols
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>
> now is a good time in the lull between 1.13 and 1.14 to roll 3rd party 
> libraries to latest versions wherever possible.  Doing this proactively helps 
> us stay ahead of CVEs and keep up with bugfixes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to