[
https://issues.apache.org/jira/browse/GEODE-8767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273171#comment-17273171
]
ASF GitHub Bot commented on GEODE-8767:
---------------------------------------
bschuchardt opened a new pull request #5962:
URL: https://github.com/apache/geode/pull/5962
A NPE was being thrown in TCPConduit.getBufferPool() because the conTable
instance
variable is nulled out when the TCPConduit is stopped. This commit
moves the buffer pool from TCPConduit's conTable object up to the enclosing
DirectChannel object. This removes the need for DirectChannel to ask
TCPConduit for the buffer pool.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NullPointerException in TCPConduit.getBufferPool due to conTable being null
> on Windows
> --------------------------------------------------------------------------------------
>
> Key: GEODE-8767
> URL: https://issues.apache.org/jira/browse/GEODE-8767
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
> Affects Versions: 1.14.0
> Reporter: Donal Evans
> Priority: Major
>
> This failure was seen in the WindowsGfshDistributedTestOpenJDK11 CI pipeline
> job:
> {noformat}
> org.apache.geode.management.MemberMXBeanDistributedTest > classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> -----------------------------------------------------------------------
> Found suspect string in 'dunit_suspect-vm1.log' at line 8350
> [fatal 2020/12/03 20:00:40.000 GMT <Timer-3> tid=630] While pushing
> message <partitioned.PRSanityCheckMessage(prid=3 processorId=0
> regionName=#testCreateRegion2 ,distTx=false)> to recipients:
> <10.0.0.75(server-2:2444)<v2>:41002, 10.0.0.75(server-3:4716)<v3>:41003,
> 10.0.0.75(server-4:6184)<v4>:41004>
> java.lang.NullPointerException
> at
> org.apache.geode.internal.tcp.TCPConduit.getBufferPool(TCPConduit.java:949)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:298)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:513)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.partitioned.PRSanityCheckMessage$1.run2(PRSanityCheckMessage.java:133)
> at
> org.apache.geode.internal.SystemTimer$SystemTimerTask.run(SystemTimer.java:334)
> at java.base/java.util.TimerThread.mainLoop(Timer.java:556)
> at java.base/java.util.TimerThread.run(Timer.java:506)
> 3 tests completed, 1 failed
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0532/test-results/distributedTest/1607032539/]
>
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0532/test-artifacts/1607032539/windows-gfshdistributedtest-OpenJDK11-1.14.0-build.0532.tgz]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
