[
https://issues.apache.org/jira/browse/GEODE-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271809#comment-17271809
]
ASF GitHub Bot commented on GEODE-8857:
---------------------------------------
jdeppe-pivotal opened a new pull request #5949:
URL: https://github.com/apache/geode/pull/5949
- This fixes an issue with hits/misses stats.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis SMOVE command should not do type checking in the executor
> ---------------------------------------------------------------
>
> Key: GEODE-8857
> URL: https://issues.apache.org/jira/browse/GEODE-8857
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Since there is a type check in the executor, it results in stats
> (hits/misses) being updated which is not desirable.
> Since there are already set-type checks in place for when a set is retrieved
> this check should not be necessary.
> Add a test case for this to {{AbstractSMoveIntegrationTest}} and remove any
> relevant {{@Ignores}} in {{AbstractHistsMissesIntegrationTest}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
