[
https://issues.apache.org/jira/browse/GEODE-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270533#comment-17270533
]
ASF GitHub Bot commented on GEODE-8830:
---------------------------------------
codecov-io edited a comment on pull request #720:
URL: https://github.com/apache/geode-native/pull/720#issuecomment-760355579
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=h1)
Report
> Merging
[#720](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=desc)
(4ca9432) into
[develop](https://codecov.io/gh/apache/geode-native/commit/ec823095d0efe74e025d773b7bffefadc9261f70?el=desc)
(ec82309) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #720 +/- ##
===========================================
- Coverage 75.05% 75.00% -0.05%
===========================================
Files 645 645
Lines 49779 49779
===========================================
- Hits 37360 37336 -24
- Misses 12419 12443 +24
```
| [Impacted
Files](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[...che/src/InternalCacheTransactionManager2PCImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0ludGVybmFsQ2FjaGVUcmFuc2FjdGlvbk1hbmFnZXIyUENJbXBsLmNwcA==)
| `74.11% <100.00%> (+11.76%)` | :arrow_up: |
|
[cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw)
| `81.25% <0.00%> (-18.75%)` | :arrow_down: |
|
[...tion-test/testThinClientRemoteQueryFailoverPdx.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVF1ZXJ5RmFpbG92ZXJQZHguY3Bw)
| `85.48% <0.00%> (-4.04%)` | :arrow_down: |
|
[cppcache/src/ThinClientBaseDM.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRCYXNlRE0uY3Bw)
| `69.09% <0.00%> (-2.43%)` | :arrow_down: |
|
[cppcache/src/PdxTypeRegistry.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1BkeFR5cGVSZWdpc3RyeS5jcHA=)
| `79.10% <0.00%> (-2.24%)` | :arrow_down: |
|
[cppcache/src/TcrMessage.hpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1Rjck1lc3NhZ2UuaHBw)
| `98.00% <0.00%> (-2.00%)` | :arrow_down: |
|
[cppcache/src/CacheTransactionManagerImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlVHJhbnNhY3Rpb25NYW5hZ2VySW1wbC5jcHA=)
| `81.72% <0.00%> (-1.62%)` | :arrow_down: |
|
[cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==)
| `78.02% <0.00%> (-1.10%)` | :arrow_down: |
|
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
| `76.98% <0.00%> (-0.98%)` | :arrow_down: |
|
[cppcache/src/LRUEntriesMap.cpp](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xSVUVudHJpZXNNYXAuY3Bw)
| `60.17% <0.00%> (-0.44%)` | :arrow_down: |
| ... and [7
more](https://codecov.io/gh/apache/geode-native/pull/720/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=footer).
Last update
[ec82309...4ca9432](https://codecov.io/gh/apache/geode-native/pull/720?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Exceptions not correctly re-thrown in the tx manager
> ----------------------------------------------------
>
> Key: GEODE-8830
> URL: https://issues.apache.org/jira/browse/GEODE-8830
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.12.0, 1.13.0, 1.13.1
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> Under several transactional scenarios exceptions are converted from its more
> specific type to *Exception* type within the internal code of the native
> client. The scenarios are the following ones:
> # Whenever a transaction commit conflicts the native client user would
> expect a *CommitConflictException*, but instead the user can only catch an
> exception of type *Exception*.
> # Whenever a transaction prepare conflicts the native client user would
> expect a *CommitConflictException*, but instead the user can only catch an
> exception of type *Exception*.
> # Whenever rollback/prepare/commit is executed with no transaction ongoing
> the native client user would expect an *IllegalStateException*, but instead
> the user can only catch an exception of type *Exception*.
> ----
> *Example:*
> {code:c++}
> auto tx_manager = cache.getCacheTransactionManager();
> // First transaction starts here
> tx_manager->begin();
> region->put("key", "A");
> // First transaction is suspended before doing the commit
> auto& tx_id = txm->suspend();
> // Second transaction starts here
> tx_manager->begin();
> region->put("key", "B");
> tx_manager->commit();
> // After successfully committing the second transaction, the first
> transaction is resumed
> tx_manager->resume(tx_id);
> try {
> tx_manager->commit();
> }
> catch(CommitConflictException& ex) {
> // This is what should be in the output in this example
> std::cerr << "A conflict occurred while committing the transaction!" <<
> std::endl;
> }
> catch(Exception& ex) {
> // However, as there is some issue with exception handling, this is what's
> currently shown
> std::cerr << "An unknown exception occurred while committing the
> transaction!" << std::endl;
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
