[
https://issues.apache.org/jira/browse/GEODE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269857#comment-17269857
]
ASF GitHub Bot commented on GEODE-8601:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #678:
URL: https://github.com/apache/geode-native/pull/678#discussion_r561935094
##########
File path: clicache/src/DistributedSystem.cpp
##########
@@ -404,9 +404,9 @@ namespace Apache
void DistributedSystem::HandleMemoryPressure(System::Object^ state)
{
// TODO global - Need single memory pressue event running?
Review comment:
It's likely meant to get invoked by .NET garbage collector but if they
was never hooked up then I'd agree to remove it.
##########
File path: clicache/src/impl/MemoryPressureTask.hpp
##########
@@ -30,14 +30,14 @@ namespace Apache
namespace Client
{
- class MemoryPressureHandler
- : public ACE_Event_Handler
+ class MemoryPressureTask
+ : public apache::geode::client::ExpiryTask
Review comment:
Worse... this is C++/CLI. As of the last time I tried about 3 years ago
there wasn't a formatted they didn't choke on something. Most choked on
generics. I should take another look.
We can format C# with clang-format but we have very little of that. I have a
todo to hook it up some day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace ACE ExpiryTaskManager impl by boost::asio one
> -----------------------------------------------------
>
> Key: GEODE-8601
> URL: https://issues.apache.org/jira/browse/GEODE-8601
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS A* native client contributor
> *I WOULD LIKE* to replace ACE implementation of ExpiryTaskManager for a
> boost::asio one
> *SO THAT* all issues related to it disappear, the implementation is more
> simple and move away from ACE as it's the project policy for a while.
> —
> *Additional information*
> Current implementation of ExpiryTaskManager is causing issue GEODE-8535 and
> some other related, not yet reported.
> Also, as I am aware the project is moving away from ACE, so I'd say this is
> the perfect oportunity to replace ExpiryTaskManager implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
