[ https://issues.apache.org/jira/browse/GEODE-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266985#comment-17266985 ]
ASF GitHub Bot commented on GEODE-8543: --------------------------------------- codecov-io edited a comment on pull request #705: URL: https://github.com/apache/geode-native/pull/705#issuecomment-754919087 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=h1) Report > Merging [#705](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=desc) (12d7a95) into [develop](https://codecov.io/gh/apache/geode-native/commit/4dd2ceb9ef0dd081039bad76cdb78a3a6cc0a2fd?el=desc) (4dd2ceb) will **decrease** coverage by `0.03%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #705 +/- ## =========================================== - Coverage 74.09% 74.05% -0.04% =========================================== Files 642 642 Lines 50812 50812 =========================================== - Hits 37647 37631 -16 - Misses 13165 13181 +16 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/src/ThinClientBaseDM.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRCYXNlRE0uY3Bw) | `68.33% <100.00%> (-0.56%)` | :arrow_down: | | [...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=) | `91.20% <0.00%> (-3.71%)` | :arrow_down: | | [cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=) | `62.47% <0.00%> (-3.21%)` | :arrow_down: | | [cppcache/src/ExecutionImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4ZWN1dGlvbkltcGwuY3Bw) | `69.92% <0.00%> (-0.40%)` | :arrow_down: | | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `75.74% <0.00%> (-0.16%)` | :arrow_down: | | [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `56.28% <0.00%> (-0.06%)` | :arrow_down: | | [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `77.38% <0.00%> (+0.07%)` | :arrow_up: | | [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `93.57% <0.00%> (+0.71%)` | :arrow_up: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `56.47% <0.00%> (+0.98%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/geode-native/pull/705/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=footer). Last update [4dd2ceb...12d7a95](https://codecov.io/gh/apache/geode-native/pull/705?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Client disconnects from server due to exception on other server > --------------------------------------------------------------- > > Key: GEODE-8543 > URL: https://issues.apache.org/jira/browse/GEODE-8543 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Alberto Bustamante Reyes > Assignee: Jakov Varenina > Priority: Major > Labels: pull-request-available > > In ThinClientBaseDM::handleEPError when the client receives an exception from > a given endpoint, it will mark that server dead if in the exception contains > "java.lang.OutOfMemoryError", > "org.apache.geode.distributed.ShutdownException" or > "org.apache.geode.cache.CacheClosedException" ( in > ThinClientBaseDM::unrecoverableServerError() ) > The problem is that the server causing the exception can be a different > server than the endpoint the client is connected to. In that case, > the client will wrongly close a connection to a working server. -- This message was sent by Atlassian Jira (v8.3.4#803005)