[ 
https://issues.apache.org/jira/browse/GEODE-8833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265542#comment-17265542
 ] 

ASF GitHub Bot commented on GEODE-8833:
---------------------------------------

pivotal-eshu opened a new pull request #5904:
URL: https://github.com/apache/geode/pull/5904


     For persistent region, even though a version tag is not recovered, the 
possibleDuplicate
     flag is still needed to be set for the cleint retry message.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> client event.setPossibleDuplicate sometimes is not set correctly
> ----------------------------------------------------------------
>
>                 Key: GEODE-8833
>                 URL: https://issues.apache.org/jira/browse/GEODE-8833
>             Project: Geode
>          Issue Type: Bug
>          Components: regions
>    Affects Versions: 1.1.0
>            Reporter: Eric Shu
>            Assignee: Eric Shu
>            Priority: Major
>
> In Put command, geode sets event possibleDuplicate flag to true if the event 
> is a retry. However, it could then set to false if it can not successfully 
> find the version tag. In persistence case, this is incorrect as there is a 
> case that data can be recovered from persistence.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to