[
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261705#comment-17261705
]
ASF GitHub Bot commented on GEODE-8626:
---------------------------------------
jchen21 commented on a change in pull request #5637:
URL: https://github.com/apache/geode/pull/5637#discussion_r554270893
##########
File path:
geode-connectors/src/distributedTest/java/org/apache/geode/connectors/jdbc/internal/cli/CreateMappingCommandDUnitTest.java
##########
@@ -1142,7 +1142,7 @@ public void createMappingWithExistingQueueFails() {
+ " must not already exist.");
}
- private static class Employee implements PdxSerializable {
+ public static class Employee implements PdxSerializable {
Review comment:
On the surface, it seems a trivial change from `private` to `public`, in
order to fix the exception. However, under the hood, it is doing unnecessary
serialization and deserialization of the `Employee` class. Because
`getPdxTypeForClass()`, `generatePdxTypeForClass() ` and `createInstance()` are
moved from `CreateMappingPreconditionCheckFunction` to
`JdbcConnectorServiceImpl`, which is probably because you want to use these
methods in `RegionMappingConfiguration`.
I would recommend keeping `getPdxTypeForClass()`, `generatePdxTypeForClass()
` and `createInstance()` in `CreateMappingPreconditionCheckFunction`. And in
`RegionMappingConfiguration`, implement similar methods. Though it looks like
duplicating the code, it does avoid unnecessary serialization and
deserialization of user defined classes like `Employee`, which is more
important.
And I don't think adding more methods to `JdbcConnectorService` is
necessary. e.g. `createDefaultFieldMapping()` is something you want to
automatically achieve for the users, so it is not necessary be exposed as an
API. Just put it as a private method in `RegionMappingConfiguration` should be
good. The same reason applies for `getTableMetaDataView()` and
`getPdxTypeForClass`. Basically, keep `JdbcConnectorService` unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
> ------------------------------------------------------------------------
>
> Key: GEODE-8626
> URL: https://issues.apache.org/jira/browse/GEODE-8626
> Project: Geode
> Issue Type: Improvement
> Components: jdbc
> Reporter: Masaki Yamakawa
> Priority: Minor
> Labels: pull-request-available
>
> When configuring Simple JDBC Connector with gfsh, I don't need to create
> field-mapping, the default field-mapping will be created from pdx and table
> meta data.
> On the other hand, when using cache.xml(cluster.xml), pdx and table meta data
> cannot be used, and field-mapping must be described in cache.xml.
> I would like to create field-mapping defaults based on pdx and table meta
> data when using cache.xml.
> If field-mapping is specified in cache.xml, the xml setting has priority, and
> only if there are no field-mapping tags.
> cache.xml will be as follows:
> {code:java}
> <region name="Region1" refid="REPLICATE">
> <jdbc:mapping
> data-source="TestDataSource"
> table="employees"
> pdx-name="org.apache.geode.connectors.jdbc.Employee"
> ids="id">
> <!-- no need to jdbc:field-mapping tag
> <jdbc:field-mapping pdx-name="id" pdx-type="STRING" jdbc-name="id"
> jdbc-type="VARCHAR" jdbc-nullable="false"/>
> <jdbc:field-mapping pdx-name="name" pdx-type="STRING"
> jdbc-name="name" jdbc-type="VARCHAR" jdbc-nullable="true"/>
> <jdbc:field-mapping pdx-name="age" pdx-type="INT" jdbc-name="age"
> jdbc-type="INTEGER" jdbc-nullable="true"/>
> -->
> </jdbc:mapping>
> </region>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
