[ 
https://issues.apache.org/jira/browse/GEODE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260767#comment-17260767
 ] 

ASF subversion and git services commented on GEODE-8786:
--------------------------------------------------------

Commit 81cd180f08fde785b13054007887a20c58028e8e in geode's branch 
refs/heads/develop from Hale Bales
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=81cd180 ]

GEODE-8786 redis info command hit miss ratios (#5875)

* GEODE-8786: fix hit/miss ratios in redis stats

- add enum for keyspace increment type
- remove clearall() method
- add tests for supported commands that do not update the stats
- use boolean to indicate if stats should be updated
- get the s*store command tests working
- add internal pttl to be called from the expire command to avoid updating the 
stats
- move the updateStats boolean up a level
- remove unused executors
- change s*store stats integrations tests to reflect behavior in native redis
- fix bitop test
- add INTERNAL command type
- fix supported commands dunit tests to allow for new internal commands
- changed tests to use delegate methods
- remove unecessary pubsub and connection tests. they don't have anything to do 
with key hits/misses
- remove unecessary getRedisString and getRedisHash methods. leaving only the 
method that takes a boolean for updating the stats

Co-authored-by: Ray Ingles <ring...@vmware.com>
Co-authored-by: john Hutchison <hutchiso...@vmware.com>

> INFO command hit/miss ratios should match native Redis
> ------------------------------------------------------
>
>                 Key: GEODE-8786
>                 URL: https://issues.apache.org/jira/browse/GEODE-8786
>             Project: Geode
>          Issue Type: Bug
>          Components: redis
>    Affects Versions: 1.14.0
>            Reporter: Raymond Ingles
>            Priority: Major
>              Labels: pull-request-available
>
> Current hit/miss ratios for Geode Redis stats do not match those for native 
> Redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to