[
https://issues.apache.org/jira/browse/GEODE-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250738#comment-17250738
]
ASF GitHub Bot commented on GEODE-8798:
---------------------------------------
DonalEvans opened a new pull request #5863:
URL: https://github.com/apache/geode/pull/5863
- Validate the format of the --start-time and --end-time arguments
- Validate that the --start-time and --end-time arguments can be
correctly parsed
- Output the values for --start-time and --end-time as used by the
function to allow users to check that they're as expected when specified
- Update documentation to reflect the new output and better explain the
behaviour when the arguments are provided
Authored-by: Donal Evans <doev...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> export logs command with --start-time or --end-time arguments needs
> improvement
> -------------------------------------------------------------------------------
>
> Key: GEODE-8798
> URL: https://issues.apache.org/jira/browse/GEODE-8798
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
> Affects Versions: 1.12.0, 1.14.0, 1.13.1
> Reporter: Donal Evans
> Assignee: Donal Evans
> Priority: Major
>
> If an invalid or improperly formatted argument for --start-time or --end-time
> is provided to the export logs gfsh command, the actual time cutoffs used to
> determine which logs to export may be inconsistent or unexpected, but no
> indication is given to the user that anything is wrong.
> In addition to this, the documentation for the command could be made clearer
> to better allow users to understand the correct use of the arguments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
