[
https://issues.apache.org/jira/browse/GEODE-8789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249423#comment-17249423
]
ASF GitHub Bot commented on GEODE-8789:
---------------------------------------
DonalEvans merged pull request #5850:
URL: https://github.com/apache/geode/pull/5850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent logging when using BaseCommand.writeRegionDestroyedEx() leads to
> region name being repeated.
> ---------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8789
> URL: https://issues.apache.org/jira/browse/GEODE-8789
> Project: Geode
> Issue Type: Improvement
> Components: logging
> Reporter: Donal Evans
> Assignee: Donal Evans
> Priority: Major
> Labels: pull-request-available
>
> The method BaseCommand.writeRegionDestroyedEx() takes a String "title" and
> String "regionName" and uses them to construct an exception message. However,
> some areas of code that call this method format the "title" String to already
> contain the region name, leading to the name being logged twice and
> potentially causing confusion. Calls to this method should be changed to not
> include the region name in the "title" String.
> {code:java}
> protected static void writeRegionDestroyedEx(Message msg, String regionName,
> String title,
> ServerConnection serverConnection) throws IOException {
> String reason = serverConnection.getName() + ": Region named " +
> regionName + title;
> RegionDestroyedException ex = new RegionDestroyedException(reason,
> regionName);
> if (serverConnection.getTransientFlag(REQUIRES_CHUNKED_RESPONSE)) {
> writeChunkedException(msg, ex, serverConnection);
> } else {
> writeException(msg, ex, false, serverConnection);
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
