[ https://issues.apache.org/jira/browse/GEODE-8789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donal Evans reassigned GEODE-8789: ---------------------------------- Assignee: Donal Evans > Inconsistent logging when using BaseCommand.writeRegionDestroyedEx() leads to > region name being repeated. > --------------------------------------------------------------------------------------------------------- > > Key: GEODE-8789 > URL: https://issues.apache.org/jira/browse/GEODE-8789 > Project: Geode > Issue Type: Improvement > Components: logging > Reporter: Donal Evans > Assignee: Donal Evans > Priority: Major > > The method BaseCommand.writeRegionDestroyedEx() takes a String "title" and > String "regionName" and uses them to construct an exception message. However, > some areas of code that call this method format the "title" String to already > contain the region name, leading to the name being logged twice and > potentially causing confusion. Calls to this method should be changed to not > include the region name in the "title" String. > {code:java} > protected static void writeRegionDestroyedEx(Message msg, String regionName, > String title, > ServerConnection serverConnection) throws IOException { > String reason = serverConnection.getName() + ": Region named " + > regionName + title; > RegionDestroyedException ex = new RegionDestroyedException(reason, > regionName); > if (serverConnection.getTransientFlag(REQUIRES_CHUNKED_RESPONSE)) { > writeChunkedException(msg, ex, serverConnection); > } else { > writeException(msg, ex, false, serverConnection); > } > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)