[
https://issues.apache.org/jira/browse/GEODE-8665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249336#comment-17249336
]
ASF GitHub Bot commented on GEODE-8665:
---------------------------------------
gesterzhou commented on a change in pull request #5801:
URL: https://github.com/apache/geode/pull/5801#discussion_r542832250
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ValidateOfflineDiskStoreDUnitTest.java
##########
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static
org.apache.geode.distributed.ConfigurationProperties.HTTP_SERVICE_PORT;
+import static org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER;
+import static
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_PORT;
+import static
org.apache.geode.distributed.ConfigurationProperties.JMX_MANAGER_START;
+import static org.apache.geode.distributed.ConfigurationProperties.LOCATORS;
+import static org.apache.geode.distributed.ConfigurationProperties.LOG_FILE;
+import static
org.apache.geode.distributed.ConfigurationProperties.MAX_WAIT_TIME_RECONNECT;
+import static
org.apache.geode.distributed.ConfigurationProperties.MEMBER_TIMEOUT;
+import static
org.apache.geode.internal.AvailablePortHelper.getRandomAvailableTCPPorts;
+import static org.apache.geode.internal.lang.SystemPropertyHelper.GEODE_PREFIX;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.Disconnect.disconnectAllFromDS;
+import static org.apache.geode.test.dunit.Invoke.invokeInEveryVM;
+import static org.apache.geode.test.dunit.VM.getVM;
+import static org.apache.geode.test.dunit.VM.getVMId;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.mock;
+
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.PrintStream;
+import java.io.Serializable;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.stream.IntStream;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.distributed.LocatorLauncher;
+import org.apache.geode.distributed.ServerLauncher;
+import org.apache.geode.distributed.internal.InternalLocator;
+import org.apache.geode.internal.lang.SystemPropertyHelper;
+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.DistributedRule;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+import
org.apache.geode.test.junit.rules.serializable.SerializableTemporaryFolder;
+
+public class ValidateOfflineDiskStoreDUnitTest implements Serializable {
+
+ @Rule
+ public transient GfshCommandRule gfsh = new GfshCommandRule();
+
+ @Rule
+ public SerializableTemporaryFolder temporaryFolder = new
SerializableTemporaryFolder();
+
+ @Rule
+ public DistributedRule distributedRule = new DistributedRule(2);
+
+ private String locatorName;
+
+ private File locatorDir;
+
+ private int locatorPort;
+
+ private int locatorJmxPort;
+
+ private static final LocatorLauncher DUMMY_LOCATOR =
mock(LocatorLauncher.class);
+
+ private static final AtomicReference<LocatorLauncher> LOCATOR =
+ new AtomicReference<>(DUMMY_LOCATOR);
+
+ private VM server;
+
+ private String serverName;
+
+ private File serverDir;
+
+ private int serverPort;
+
+ private String locators;
+
+ private static final ServerLauncher DUMMY_SERVER =
mock(ServerLauncher.class);
+
+ private static final AtomicReference<ServerLauncher> SERVER =
+ new AtomicReference<>(DUMMY_SERVER);
+
+ private final int NUM_ENTRIES = 1000;
+
+ private static final String DISK_STORE_NAME = "testDiskStore";
+
+ private static final String REGION_NAME = "testRegion";
+
+ @Before
+ public void setUp() throws Exception {
+ VM locator = getVM(0);
+ server = getVM(1);
+
+ locatorName = "locator";
+ serverName = "server";
+
+ locatorDir = temporaryFolder.newFolder(locatorName);
+
+ serverDir = temporaryFolder.newFolder(serverName);
+
+ int[] port = getRandomAvailableTCPPorts(3);
+ locatorPort = port[0];
+ locatorJmxPort = port[1];
+ serverPort = port[2];
+
+ locators = "localhost[" + locatorPort + "]";
+
+ locator.invoke(() -> startLocator(locatorName, locatorDir, locatorPort,
locatorJmxPort));
+
+ gfsh.connectAndVerify(locatorJmxPort, GfshCommandRule.PortType.jmxManager);
+
+ server.invoke(() -> startServer(serverName, serverDir, serverPort,
locators));
+ }
+
+ @After
+ public void tearDown() {
+ invokeInEveryVM(() -> {
+ SERVER.getAndSet(DUMMY_SERVER).stop();
+ LOCATOR.getAndSet(DUMMY_LOCATOR).stop();
+ });
+ disconnectAllFromDS();
+ }
+
+ @Test
+ public void testValidateOfflineDiskStoreInfo() {
+
+ createDiskStore();
+
+ createRegion();
+
+ populateRegions();
+
+ AssertRegionSizeAndDiskStore();
+
+ server.invoke(ValidateOfflineDiskStoreDUnitTest::stopServer);
+
+ server.invoke(() -> {
+ ByteArrayOutputStream byteArrayOutputStream = new
ByteArrayOutputStream();
+ PrintStream originalSystemOut = System.out;
+ System.setOut(new PrintStream(byteArrayOutputStream));
+ validateOfflineDiskStore();
+ assertThat(byteArrayOutputStream.toString())
+ .contains("Disk store contains " + NUM_ENTRIES + " compactable
records.");
+ System.setOut(originalSystemOut);
+ });
+
+ }
+
+ private void validateOfflineDiskStore() throws Exception {
+ DiskStoreImpl.offlineValidate(DISK_STORE_NAME, new File[] {serverDir});
+ }
+
+ private static void startLocator(String name, File workingDirectory, int
locatorPort,
+ int jmxPort) {
+ LOCATOR.set(new LocatorLauncher.Builder()
+ .setMemberName(name)
+ .setPort(locatorPort)
+ .setWorkingDirectory(workingDirectory.getAbsolutePath())
+ .set(JMX_MANAGER, "true")
+ .set(JMX_MANAGER_PORT, String.valueOf(jmxPort))
+ .set(JMX_MANAGER_START, "true")
+ .set(LOG_FILE, new File(workingDirectory, name +
".log").getAbsolutePath())
+ .set(MAX_WAIT_TIME_RECONNECT, "1000")
+ .set(MEMBER_TIMEOUT, "2000")
+ .build());
+
+ LOCATOR.get().start();
+
+ await().untilAsserted(() -> {
+ InternalLocator locator = (InternalLocator) LOCATOR.get().getLocator();
+ assertThat(locator.isSharedConfigurationRunning())
+ .as("Locator shared configuration is running on locator" + getVMId())
+ .isTrue();
+ });
+ }
+
+ private static void startServer(String name, File workingDirectory, int
serverPort,
+ String locators) {
+
+ System.setProperty(GEODE_PREFIX +
SystemPropertyHelper.PARALLEL_DISK_STORE_RECOVERY,
+ "true");
+
+ SERVER.set(new ServerLauncher.Builder()
+ .setDeletePidFileOnStop(Boolean.TRUE)
+ .setMemberName(name)
+ .setWorkingDirectory(workingDirectory.getAbsolutePath())
+ .setServerPort(serverPort)
+ .set(HTTP_SERVICE_PORT, "0")
+ .set(LOCATORS, locators)
+ .set(LOG_FILE, new File(workingDirectory, name +
".log").getAbsolutePath())
+ .set(MAX_WAIT_TIME_RECONNECT, "1000")
+ .set(MEMBER_TIMEOUT, "2000")
+ .build());
+
+ SERVER.get().start();
+ }
+
+ private static void stopServer() {
+ SERVER.get().stop();
+ }
+
+ private void AssertRegionSizeAndDiskStore() {
Review comment:
method name should starts with lower case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> validate offline-disk-store command is missing information
> ----------------------------------------------------------
>
> Key: GEODE-8665
> URL: https://issues.apache.org/jira/browse/GEODE-8665
> Project: Geode
> Issue Type: Bug
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> According the document
> https://geode.apache.org/docs/guide/13/managing/disk_storage/validating_disk_store.html,
> `validate offline-disk-store` command should tell the number of records that
> would be removed if you compacted the store.
> For example, according to the document
> https://geode.apache.org/docs/guide/13/managing/disk_storage/compacting_disk_stores.html:
> ```
> gfsh>validate offline-disk-store --name=ds1 --disk-dirs=backupDirectory
> /root: entryCount=6
> /partitioned_region entryCount=1 bucketCount=10
> Disk store contains 12 compactable records.
> Total number of region entries in this disk store is: 7
> ```
> However, it does not show the number of records that would be removed if you
> compacted the store. Here is how to reproduce:
> 1. gfsh>create region --name=testRegion --type=PARTITION_PERSISTENT
> 2. gfsh>put --key=1 --value=a --region=testRegion
> 3. gfsh>put --key=1 --value=b --region=testRegion
> 4. gfsh>put --key=1 --value=c --region=testRegion
> 5. gfsh>shutdown
> 6. gfsh>validate offline-disk-store --name=DEFAULT
> --disk-dirs=/Users/jchen/workspace/geode/geode-assembly/build/install/apache-geode/server1
> expectedCrfs=[1]
> expectedDrfs=[1]
> dataSerializerIds=[]
> instantiatorIds= []
> /testRegion entryCount=1 bucketCount=1
> Total number of region entries in this disk store is: 1
> It should have shown something like: Disk store contains 2 compactable
> records.
> `compact offline-disk-store` command proves that there are 2 compactable
> records:
> gfsh>compact offline-disk-store --name=DEFAULT
> --disk-dirs=/Users/jchen/workspace/geode/geode-assembly/build/install/apache-geode/server1
> Offline compaction removed 2 records.
> Cluster configuration service is not running. Configuration change is not
> persisted.
> `validate offline-disk-store` command could also show the wrong number of
> entries.
> 7. gfsh>put --key=2 --value=b --region=testRegion
> 8. gfsh>remove --region=/testRegion --key=1
> 9. gfsh>validate offline-disk-store --name=DEFAULT
> --disk-dirs=/Users/jchen/workspace/geode/geode-assembly/build/install/apache-geode/server1
> expectedCrfs=[1]
> expectedDrfs=[1]
> dataSerializerIds=[]
> instantiatorIds= []
> /testRegion entryCount=2 bucketCount=2
> Total number of region entries in this disk store is: 2
> The correct number of entries should be 1, not 2.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
