[ 
https://issues.apache.org/jira/browse/GEODE-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244355#comment-17244355
 ] 

ASF GitHub Bot commented on GEODE-2644:
---------------------------------------

nabarunnag opened a new pull request #5817:
URL: https://github.com/apache/geode/pull/5817


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to [email protected].
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Provide ability to configure Geode appenders in log4j2.xml
> ----------------------------------------------------------
>
>                 Key: GEODE-2644
>                 URL: https://issues.apache.org/jira/browse/GEODE-2644
>             Project: Geode
>          Issue Type: Improvement
>          Components: configuration, logging
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: AlertAppender, Log4j2, LogWriterAppender, log4j2.xml, 
> pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> Presently Geode dynamically creates, adds and removes AlertAppender and 
> LogWriterAppender by manipulating log4j2 core API. We should move the bulk of 
> the Appender functionality to internal classes and just leave the Appenders 
> registered with log4j2 during the life of the JVM. 
> This allows us to enable and configure our Appenders via log4j2.xml and 
> control the Cache-controlled lifecycle internally without having to add and 
> remove custom Appender instances.
> The code would then become simpler, we could avoid invoking log4j2 core APIs, 
> and users would have control over configuring our use of log4j2 completely 
> within the .xml file. Presently, a user cannot configure our AlertAppender or 
> LogWriterAppender in log4j2.xml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to