[
https://issues.apache.org/jira/browse/GEODE-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243601#comment-17243601
]
ASF GitHub Bot commented on GEODE-8763:
---------------------------------------
pivotal-jbarrett commented on pull request #5806:
URL: https://github.com/apache/geode/pull/5806#issuecomment-738466652
> this looks better. although I think lines 85-97 could be simplified to
just:
>
> set -e
> ./run_against_baseline.sh ...
> set +e
Not really. `-e` causes errors to bubble up and exit the script, which in
this case we want to avoid to loop 5 times, but only on the execution of this
line. The logic for checking the iteration found could be simplified if we
captured the error code and exited with that code after the 5th iteration.
```
exit_code=0
for ... {
...
set +e
./run_against...
set -e
exit_code = $?
if [[ $exit_code -eq 0 ]]; then
break;
fi
}
...
exit $exit_code
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Benchmark CI only runs tests 4 times
> ------------------------------------
>
> Key: GEODE-8763
> URL: https://issues.apache.org/jira/browse/GEODE-8763
> Project: Geode
> Issue Type: Bug
> Components: benchmarks, ci
> Reporter: Helena Bales
> Assignee: Helena Bales
> Priority: Major
> Labels: pull-request-available
>
> The benchmark has a retry mechanism that is supposed to run all tests, then
> rerun any failed tests. If tests are still failing then it should retry those
> tests, for a total of 5 test runs (including the first run of all the tests).
> Currently it only runs the tests a total of 4 times.
> Increase the number of runs to 5 to increase the tolerance for variance in
> tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
