[
https://issues.apache.org/jira/browse/GEODE-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242562#comment-17242562
]
ASF GitHub Bot commented on GEODE-8755:
---------------------------------------
yozaner1324 commented on a change in pull request #5800:
URL: https://github.com/apache/geode/pull/5800#discussion_r534359215
##########
File path:
geode-assembly/src/integrationTest/java/org/apache/geode/BundledJarsJUnitTest.java
##########
@@ -67,7 +67,7 @@ public void verifyBundledJarsHaveNotChanged() throws
IOException {
sortedJars.entrySet().stream().map(entry ->
removeVersion(entry.getKey()));
Set<String> bundledJarNames = new
TreeSet<>(lines.collect(Collectors.toSet()));
- Files.write(Paths.get("bundled_jars.txt"), bundledJarNames);
+ Files.write(Paths.get("..", "bundled_jars.txt"), bundledJarNames);
Review comment:
The three mentioned tests are the only ones I'm aware of that write
files that need to be accessed after the test runs. I searched for all other
occurrences of "Files.write" and none seemed important. I'm not sure there is a
better way to identify which files are important vs random temp files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> BundledJarsJUnitTest writes bundled_jars.txt file to wrong dir
> --------------------------------------------------------------
>
> Key: GEODE-8755
> URL: https://issues.apache.org/jira/browse/GEODE-8755
> Project: Geode
> Issue Type: Test
> Components: tests
> Affects Versions: 1.14.0
> Reporter: Dale Emery
> Assignee: Dale Emery
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> BundledJarsJUnitTest instructs the user to examine and vet the
> {{geode-assembly/build/integrationTest/bundled_jars.txt}} file.
> But since GEODE-8637, which causes each test class to run in a unique working
> directory, the file now ends up in a directory other than the one in the
> instructions, like:
> {{geode-assembly/build/integrationTest/test-worker-00014/bundled_jars.txt}}.
> This is confusing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
