[
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242255#comment-17242255
]
ASF GitHub Bot commented on GEODE-8202:
---------------------------------------
alb3rtobr commented on a change in pull request #5600:
URL: https://github.com/apache/geode/pull/5600#discussion_r534079046
##########
File path:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcherJUnitTest.java
##########
@@ -77,4 +132,160 @@ public void
getConnectionShouldCreateNewConnectionWhenServerIsNull() {
verify(dispatcher, times(1)).initializeConnection();
verify(dispatcher, times(2)).getConnectionLifeCycleLock();
}
+
+ @Test
+ public void
enforceThreadsConnectSameReceiver_initializeParallelSenderConnection_retriesAreNotUsed()
{
Review comment:
I read the article when you posted it the first time (interesting
reading, thanks!) and tried to follow the
`UnitOfWork_StateUnderTest_ExpectedBehavior` schema they propose (which btw I
found it very similar to the `given-when-then` naming approach). It seems I did
not understand the article in the same way as you, sorry. I used
`enforceThreadsConnectSameReceiver` as `UnitOfWork` because this is what this
PR is introducing.
The names you have proposed look fine for me, they really look like
requirements when you read them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> New option for serial gw sender threads start when receivers share ip and port
> ------------------------------------------------------------------------------
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
> Issue Type: Improvement
> Reporter: Alberto Bustamante Reyes
> Assignee: Alberto Bustamante Reyes
> Priority: Major
> Labels: pull-request-available
>
> RFC:
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
