[
https://issues.apache.org/jira/browse/GEODE-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241085#comment-17241085
]
ASF GitHub Bot commented on GEODE-8521:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5763:
URL: https://github.com/apache/geode/pull/5763#discussion_r532930752
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringProcess.java
##########
@@ -33,73 +31,86 @@
public class ThreadsMonitoringProcess extends TimerTask {
- private final ThreadsMonitoring threadsMonitoring;
- private ResourceManagerStats resourceManagerStats = null;
private static final Logger logger = LogService.getLogger();
+
+ private final ThreadsMonitoring threadsMonitoring;
private final int timeLimit;
private final InternalDistributedSystem internalDistributedSystem;
- private final Properties nonDefault = new Properties();
- private final DistributionConfigImpl distributionConfigImpl =
- new DistributionConfigImpl(nonDefault);
+ private ResourceManagerStats resourceManagerStats = null;
protected ThreadsMonitoringProcess(ThreadsMonitoring tMonitoring,
- InternalDistributedSystem iDistributedSystem) {
- this.timeLimit = this.distributionConfigImpl.getThreadMonitorTimeLimit();
+ InternalDistributedSystem iDistributedSystem, int timeLimit) {
Review comment:
I changed the name to timeLimitMillis. This unit is determined by an
external geode property so it will always be milliseconds
##########
File path:
geode-core/src/test/java/org/apache/geode/internal/monitoring/ThreadsMonitoringProcessJUnitTest.java
##########
@@ -34,11 +31,13 @@
*/
public class ThreadsMonitoringProcessJUnitTest {
+ private static final int TIME_LIMIT = 1000;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add P2P message reader threads to thread monitoring
> ---------------------------------------------------
>
> Key: GEODE-8521
> URL: https://issues.apache.org/jira/browse/GEODE-8521
> Project: Geode
> Issue Type: Wish
> Components: messaging
> Reporter: Kirk Lund
> Assignee: Darrel Schneider
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> Add P2P message reader threads to thread monitoring to help with identifying
> stuck P2P message readers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
