[
https://issues.apache.org/jira/browse/GEODE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240337#comment-17240337
]
ASF GitHub Bot commented on GEODE-8656:
---------------------------------------
gesterzhou commented on pull request #5775:
URL: https://github.com/apache/geode/pull/5775#issuecomment-735441681
I reviewed the code. It's the phase 2 of a good feature. The phase 1 is
GEODE-7565. At that time, there's already a potential issue to break backward
compatibility. Base on my limited knowledge, I feel that introducing
ServerLocationAndMemberId to replace ServerLocation might not be the correct
way. The better way should be to introduce a new field "String memberId" into
the ServerLocation class, then use toDataPre_GEODE_1_14_0_0 and
fromDataPre_GEODE_1_14_0_0 in ServerLocation to handle the new field for
rollingupgrade.
As for how to find such issue earlier in geode, we do have rollingupgrade
dunit tests. The pull request does not have this type of test, then it has to
rely on hydra to find the issue. It's not hydra's fault though. We should feel
happy that hydra protected us and found the issue today.
As for how to cooperate with remote committer, it's a long story. I'd like
to cooperate with remote committer to enhance the GEODE-8656. But even I am not
skillful to know the root cause and how to fix, as the rule of regression
analysis, we should still revert first then re-fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ping not sent to the right gateway receiver endpoint when several receivers
> have the same hostname-for-senders value
> --------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8656
> URL: https://issues.apache.org/jira/browse/GEODE-8656
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> When several gateway receivers have the same value for hostname-for-senders
> (for example when running Geode under kubernetes and a load balancer balances
> the load among the remote servers), the ping messages sent from the gateway
> sender client are only sent to the receiver (endpoint) to which the sender
> connected first.
> The other receivers will not get the ping message which will imply that the
> connections towards them will be closed after the configured timeout expires.
> This ticket is a continuation of the work done ticket GEODE-7565.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
