[
https://issues.apache.org/jira/browse/GEODE-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238941#comment-17238941
]
ASF GitHub Bot commented on GEODE-8735:
---------------------------------------
gaussianrecurrence commented on pull request #700:
URL: https://github.com/apache/geode-native/pull/700#issuecomment-733945720
There's one thing I am not sure about if it's the right call and that's
having added a modification of GenerateExportHeaders. This is necessary in
order to specify the visibility flags to the factory function added to
cpp-integration-test for testing purposes. Thing is GenerateExportHeaders does
not support executables, so that's the rationale behind
ExecutableExportHeader.cmake
Please let me know what you think about it and if you think there might be a
better alternative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable factory lookup logic to look for symbols in the application
> ------------------------------------------------------------------
>
> Key: GEODE-8735
> URL: https://issues.apache.org/jira/browse/GEODE-8735
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.13.1
> Reporter: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> *AS A* native client contributor
> *I WANT* to be able to specify factory names within the application space
> *SO THAT* the user does not need to create a separate shared library to load
> several items like partition resolvers, cache loaders, cache writers,
> partition resolvers...
> ----
> *Additional information*
> The rationale for this change is that if the user wants to declaratively
> specify a partition resolver, right now the only way is by creating the
> shared library.
> So the idea would be to change the current factory implementation, so library
> name is an optional field, and whenever "library-name" is not specified, the
> client will look for symbols within the application instead.
> *For example:*
> Using this region definition:
> {code:xml}
> <region name="region_part_a">
> <region-attributes refid="CACHING_PROXY"
> pool-name="partitioned-pool">
> <partition-resolver library-function-name="createPartitionResolver"/>
> </region-attributes>
> </region>
> {code}
> And within the application defining this function:
> {code:cpp}
> APPLICATION_EXPORT PartitionResolver* createPartitionResolver()
> {
> return new StringPrefixPartitionResolver{};
> }
> {code}
> You could declaratively create a region which uses the
> StringPrefixPartitionResolver.
> *IMPORTANT.* Take into account that documentation should be updated in order
> to indicate that library-name will become an optional field and what it means
> whenever it's not present.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
