[ 
https://issues.apache.org/jira/browse/GEODE-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235797#comment-17235797
 ] 

ASF GitHub Bot commented on GEODE-8734:
---------------------------------------

DonalEvans opened a new pull request #5764:
URL: https://github.com/apache/geode/pull/5764


   Authored-by: Donal Evans <doev...@vmware.com>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [N/A] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LinuxProcFsStatistics.getNetStatStats() may incorrectly parse 
> /proc/net/netstat file
> ------------------------------------------------------------------------------------
>
>                 Key: GEODE-8734
>                 URL: https://issues.apache.org/jira/browse/GEODE-8734
>             Project: Geode
>          Issue Type: Bug
>          Components: statistics
>    Affects Versions: 1.12.1, 1.14.0, 1.13.1
>            Reporter: Donal Evans
>            Assignee: Donal Evans
>            Priority: Major
>
> The current implementation of the LinuxProcFsStatistics.getNetStatStats() 
> method assumes a particular ordering of stats within the /proc/net/netstat 
> file on Linux systems and uses that assumption to parse the contents of the 
> file when writing to the stats. However, different versions of Linux produce 
> /proc/net/netstat files with the stats in different positions in the file, 
> causing the incorrect stat values to be parsed and written to Geode stats, so 
> a more robust approach is needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to