[ 
https://issues.apache.org/jira/browse/GEODE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235724#comment-17235724
 ] 

ASF GitHub Bot commented on GEODE-8623:
---------------------------------------

jinmeiliao commented on a change in pull request #5743:
URL: https://github.com/apache/geode/pull/5743#discussion_r527166524



##########
File path: geode-common/src/main/java/org/apache/geode/internal/Retry.java
##########
@@ -32,18 +31,21 @@
   interface Timer {
     long nanoTime();
 
-    void sleep(long sleepTime, TimeUnit sleepTimeUnit) throws 
InterruptedException;
+    void sleep(long sleepTimeInNano) throws InterruptedException;
   }
 
-  private static class SteadyTimer implements Timer {
+  static class SteadyTimer implements Timer {
     @Override
     public long nanoTime() {
       return System.nanoTime();
     }
 
     @Override
-    public void sleep(long sleepTime, TimeUnit sleepTimeUnit) throws 
InterruptedException {
-      Thread.sleep(MILLISECONDS.convert(sleepTime, sleepTimeUnit));
+    public void sleep(long sleepTimeInNano) throws InterruptedException {
+      // avoid throwing IllegalArgumentException
+      if (sleepTimeInNano > 0) {
+        Thread.sleep(NANOSECONDS.toMillis(sleepTimeInNano));

Review comment:
       good point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Timing between DNS and Geode startup can result in permanent unknown host 
> exceptions.
> -------------------------------------------------------------------------------------
>
>                 Key: GEODE-8623
>                 URL: https://issues.apache.org/jira/browse/GEODE-8623
>             Project: Geode
>          Issue Type: Bug
>    Affects Versions: 1.9.0, 1.9.1, 1.10.0, 1.9.2, 1.11.0, 1.12.0, 1.13.0, 
> 1.14.0, 1.13.1
>            Reporter: Jacob Barrett
>            Priority: Minor
>              Labels: pull-request-available
>
> In a managed environment were local host name DNS entries and the startup of 
> Geode happen concurrently it is possible for Geode to fail name resolution in 
> the local hostname caching. If it fails to resolve the local hostname when 
> loading the caching utility class then any service dependent on this name 
> will fail without chance for recovery.
> {code}
> [error 2020/09/30 19:50:21.644 UTC <main> tid=0x1] Jmx manager could not be 
> started because java.net.UnknownHostException
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
>       at 
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
>       at 
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
>       at 
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
>       at 
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
>       at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2063)
>       at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
>       at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1239)
>       at 
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:219)
>       at 
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:171)
>       at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
>       at 
> org.apache.geode.distributed.internal.DefaultServerLauncherCacheProvider.createCache(DefaultServerLauncherCacheProvider.java:52)
>       at 
> org.apache.geode.distributed.ServerLauncher.createCache(ServerLauncher.java:887)
>       at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:803)
>       at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:732)
>       at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:251)
> Caused by: java.net.UnknownHostException
>       at 
> org.apache.geode.internal.net.SocketCreator.getLocalHost(SocketCreator.java:285)
>       at 
> org.apache.geode.management.internal.ManagementAgent.configureAndStart(ManagementAgent.java:310)
>       at 
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:131)
>       ... 14 more
> [error 2020/09/30 19:50:21.724 UTC <main> tid=0x1] 
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> Exception in thread "main" org.apache.geode.management.ManagementException: 
> java.net.UnknownHostException
>       at 
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
>       at 
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
>       at 
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
>       at 
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
>       at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2063)
>       at 
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
>       at 
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1239)
>       at 
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:219)
>       at 
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:171)
>       at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
>       at 
> org.apache.geode.distributed.internal.DefaultServerLauncherCacheProvider.createCache(DefaultServerLauncherCacheProvider.java:52)
>       at 
> org.apache.geode.distributed.ServerLauncher.createCache(ServerLauncher.java:887)
>       at 
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:803)
>       at 
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:732)
>       at 
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:251)
> Caused by: java.net.UnknownHostException
>       at 
> org.apache.geode.internal.net.SocketCreator.getLocalHost(SocketCreator.java:285)
>       at 
> org.apache.geode.management.internal.ManagementAgent.configureAndStart(ManagementAgent.java:310)
>       at 
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:131)
>       ... 14 more
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to