[
https://issues.apache.org/jira/browse/GEODE-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234076#comment-17234076
]
ASF GitHub Bot commented on GEODE-8614:
---------------------------------------
codecov-io commented on pull request #688:
URL: https://github.com/apache/geode-native/pull/688#issuecomment-729264985
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=h1)
Report
> Merging
[#688](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=desc)
(3525c10) into
[develop](https://codecov.io/gh/apache/geode-native/commit/9279098352e5c6440cade1196b9b99dcf89e90c5?el=desc)
(9279098) will **decrease** coverage by `0.05%`.
> The diff coverage is `55.71%`.
[](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #688 +/- ##
===========================================
- Coverage 74.06% 74.01% -0.06%
===========================================
Files 644 644
Lines 51189 51063 -126
===========================================
- Hits 37914 37795 -119
+ Misses 13275 13268 -7
```
| [Impacted
Files](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cppcache/include/geode/ExceptionTypes.hpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9FeGNlcHRpb25UeXBlcy5ocHA=)
| `39.84% <50.00%> (+0.34%)` | :arrow_up: |
|
[cppcache/src/ExceptionTypes.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4Y2VwdGlvblR5cGVzLmNwcA==)
| `44.31% <51.92%> (-12.83%)` | :arrow_down: |
|
[cppcache/test/ExceptionTypesTest.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvdGVzdC9FeGNlcHRpb25UeXBlc1Rlc3QuY3Bw)
| `78.57% <66.66%> (-8.93%)` | :arrow_down: |
|
[cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw)
| `56.13% <100.00%> (+0.08%)` | :arrow_up: |
|
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
| `62.24% <0.00%> (-2.75%)` | :arrow_down: |
|
[cppcache/src/PdxTypeRegistry.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1BkeFR5cGVSZWdpc3RyeS5jcHA=)
| `77.94% <0.00%> (-2.21%)` | :arrow_down: |
|
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
| `54.27% <0.00%> (-1.55%)` | :arrow_down: |
|
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
| `72.48% <0.00%> (-0.48%)` | :arrow_down: |
|
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
| `75.80% <0.00%> (-0.43%)` | :arrow_down: |
| ... and [1
more](https://codecov.io/gh/apache/geode-native/pull/688/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=footer).
Last update
[9279098...3525c10](https://codecov.io/gh/apache/geode-native/pull/688?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide an specific client-side exception for server LowMemoryException
> -----------------------------------------------------------------------
>
> Key: GEODE-8614
> URL: https://issues.apache.org/jira/browse/GEODE-8614
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.11.0, 1.12.0, 1.13.0
> Reporter: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> *AS AN* native client contributor
> *I WANT* to have a client-side exception for LowMemoryException
> *SO THAT* I can nofity accordingly from the client-side upon server
> memory-depletion.
> —
> *Additional information*
> This is the callstack of the LowMemoryException:
> {noformat}
> [error 2020/10/13 09:54:14.401405 UTC 140522117220352] Region::put: An
> exception (org.apache.geode.cache.LowMemoryException: PartitionedRegion:
> /part_a cannot process operation on key foo|0 because members
> [192.168.240.14(dms-server-1:1)<v2>:41000] are running low on memory
> at
> org.apache.geode.internal.cache.partitioned.RegionAdvisor.checkIfBucketSick(RegionAdvisor.java:482)
> at
> org.apache.geode.internal.cache.PartitionedRegion.checkIfAboveThreshold(PartitionedRegion.java:2278)
> at
> org.apache.geode.internal.cache.PartitionedRegion.putInBucket(PartitionedRegion.java:2982)
> at
> org.apache.geode.internal.cache.PartitionedRegion.virtualPut(PartitionedRegion.java:2212)
> at
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:170)
> at
> org.apache.geode.internal.cache.LocalRegion.basicUpdate(LocalRegion.java:5573)
> at
> org.apache.geode.internal.cache.LocalRegion.basicUpdate(LocalRegion.java:5533)
> at
> org.apache.geode.internal.cache.LocalRegion.basicBridgePut(LocalRegion.java:5212)
> at
> org.apache.geode.internal.cache.tier.sockets.command.Put65.cmdExecute(Put65.java:411)
> at
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:183)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMessage(ServerConnection.java:848)
> at
> org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:72)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1212)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.lambda$initializeServerConnectionThreadPool$3(AcceptorImpl.java:676)
> at
> org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119)
> at java.base/java.lang.Thread.run(Thread.java:834) ) happened at remote
> server.
> {noformat}
> Idea would be to modify *ThinClientRegion::handleServerException* in order to
> return a new error and later on, map it to a new created exception
> *Suggestions*
> The new exception could be called:
> * CacheServerLowMemoryException
> * ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
