[
https://issues.apache.org/jira/browse/GEODE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231019#comment-17231019
]
ASF GitHub Bot commented on GEODE-8672:
---------------------------------------
pivotal-eshu opened a new pull request #5746:
URL: https://github.com/apache/geode/pull/5746
* The DESTROYED token is only needed to prevent concurrent destroy op
is lost in GII. If concurrency checks are enabled, the version tag
should be able to prevent the destroy op being lost.
* Correctly set the inTokenMode to avoid a potential hang in replicate
region as invokeTXCallbacks needs to wait for the region initialization
finished, but region intialization could not due to lock held by
threads invoking callbacks.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Concurrent transactional destroy with GII could cause an entry to be removed
> and version information to be lost
> ---------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8672
> URL: https://issues.apache.org/jira/browse/GEODE-8672
> Project: Geode
> Issue Type: Bug
> Components: regions
> Affects Versions: 1.1.0
> Reporter: Eric Shu
> Assignee: Eric Shu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> In a newly rebalanced bucket, while GII is in progress, a transactional
> destroy is applied to cache. There is a logic that it should be in token mode
> and leaves the entry as a Destroyed token, even though the version tag of the
> entry indicates that it has the correct version.
> However, at end of the GII, there is a
> cleanUpDestroyedTokensAndMarkGIIComplete method removes all the destroyed
> entries – this wipes off the entry version tag information and cause the
> subsequent creates starts fresh with new version tags.
> This could leads to client server data inconsistency as the newly created
> entries will be ignored by the clients as the newly created entry has lower
> version number while client has high ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
