[
https://issues.apache.org/jira/browse/GEODE-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230891#comment-17230891
]
ASF GitHub Bot commented on GEODE-8694:
---------------------------------------
sabbey37 commented on a change in pull request #5732:
URL: https://github.com/apache/geode/pull/5732#discussion_r522374449
##########
File path: ci/scripts/execute_redis_tests.sh
##########
@@ -19,12 +19,14 @@
cd ..
-# We are currently using a personal fork for this repo because our code does
not implement all
+# We are currently using a patched version of this repo because our code does
not implement all
# Redis commands. Once all commands needed to run relevant test files are
implemented, we hope to
-# use Redis's repo instead.
-git clone --config transfer.fsckObjects=false
https://github.com/prettyClouds/redis.git
+# use Redis's repo without a patch.
+git clone --config transfer.fsckObjects=false
https://github.com/redis/redis.git
+cp geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch
redis
cd redis
-git checkout tests-geode-redis
+git checkout origin/5.0
+git am < 0001-configure-redis-tests.patch
Review comment:
It seems like the application of the patch is failing. Could be related
to this error:
```
*** Please tell me who you are.
Run
git config --global user.email "y...@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for
<geode@heavy-lifter-bc46dab9-e3b2-587d-b59e-a07a7b894615.c.apachegeode-ci.internal>)
not allowed
```
...though I tried removing my git credentials and running it locally with a
fresh clone of redis and it worked. Maybe an identity is required to apply a
patch on heavy-lifter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use fork of Redis in Gemfire org to run Redis tests in CI
> ---------------------------------------------------------
>
> Key: GEODE-8694
> URL: https://issues.apache.org/jira/browse/GEODE-8694
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Helena Bales
> Priority: Trivial
> Labels: pull-request-available
>
> Currently, we are using a contributor's personal fork of Redis to run tests
> against Geode Redis in CI. This should be switched to the fork of Redis in
> the Gemfire org. Ideally, we will eventually be able to run tests from the
> root Redis repo (currently we are unable to since we are not implementing all
> the necessary commands).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
