[
https://issues.apache.org/jira/browse/GEODE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229338#comment-17229338
]
ASF GitHub Bot commented on GEODE-8684:
---------------------------------------
sabbey37 commented on a change in pull request #5724:
URL: https://github.com/apache/geode/pull/5724#discussion_r520697519
##########
File path:
geode-assembly/src/distributedTest/java/org/apache/geode/session/tests/Tomcat9CachingClientServerValveDisabledTest.java
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.session.tests;
+
+import static
org.apache.geode.session.tests.ContainerInstall.ConnectionType.CACHING_CLIENT_SERVER;
+import static
org.apache.geode.session.tests.TomcatInstall.TomcatVersion.TOMCAT9;
+
+import java.util.function.IntSupplier;
+
+public class Tomcat9CachingClientServerValveDisabledTest extends
TomcatClientServerTest {
Review comment:
Should we add a ValveDisabled test for other versions of Tomcat? Or is
it unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setting a session's maxInactiveInterval does not work when the commit valve
> is disabled
> ---------------------------------------------------------------------------------------
>
> Key: GEODE-8684
> URL: https://issues.apache.org/jira/browse/GEODE-8684
> Project: Geode
> Issue Type: Bug
> Components: http session
> Affects Versions: 1.14.0
> Reporter: Jens Deppe
> Assignee: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> I was using the {{CommandServlet}}, in an external test, and noticed that
> when the commit valve is disabled, attempting to set the session's
> maxInactiveInterval does not cause the session's maxInactiveInterval to be
> changed and it remains at the default.
> My setup consisted of 2 Geode servers and a single Tomcat instance (9.0.39).
> I was checking the sessions with the following gfsh query:
> {code:java}
> query --query="select e.key,e.value.maxInactiveInterval from
> /gemfire_modules_sessions.entries as e
> {code}
> My {{context.xml}} includes the following:
> {code:xml}
> <Manager
> className="org.apache.geode.modules.session.catalina.Tomcat8DeltaSessionManager"
> enableLocalCache="false"
> enableCommitValve="false"
> regionAttributesId="PARTITION_REDUNDANT"
> />
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
