[
https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226095#comment-17226095
]
ASF GitHub Bot commented on GEODE-8547:
---------------------------------------
jinmeiliao commented on a change in pull request #5567:
URL: https://github.com/apache/geode/pull/5567#discussion_r517420791
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommand.java
##########
@@ -95,7 +96,8 @@ private ResultModel toMissingDiskStoresTabularResult(
ResultModel result = new ResultModel();
boolean hasMissingDiskStores = missingDiskStores.length != 0;
- boolean hasMissingColocatedRegions = !missingColocatedRegions.isEmpty();
+ boolean hasMissingColocatedRegions =
Review comment:
this variable is not used anymore.
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommand.java
##########
@@ -95,7 +96,8 @@ private ResultModel toMissingDiskStoresTabularResult(
ResultModel result = new ResultModel();
boolean hasMissingDiskStores = missingDiskStores.length != 0;
Review comment:
actually you can get rid of this variable and inline this too, to make
it symetric.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Command "show missing-disk-stores" not working, when all servers are down
> -------------------------------------------------------------------------
>
> Key: GEODE-8547
> URL: https://issues.apache.org/jira/browse/GEODE-8547
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mario Ivanac
> Assignee: Mario Ivanac
> Priority: Major
> Labels: needs-review, pull-request-available
>
> If cluster with 2 locators and 2 servers was ungracefully shutdown it can
> happen that locators that are able to start up are not having most recent
> data to bring up Cluster Configuration Service.
> If we excute command "show missing-disk-stores" it will not work, since all
> servers are down,
> so we are stuck in this situation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
