[
https://issues.apache.org/jira/browse/GEODE-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223107#comment-17223107
]
ASF GitHub Bot commented on GEODE-8668:
---------------------------------------
sabbey37 commented on a change in pull request #5682:
URL: https://github.com/apache/geode/pull/5682#discussion_r514290020
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisConstants.java
##########
@@ -30,6 +30,8 @@
public static final String SERVER_ERROR_MESSAGE =
"The server had an internal error please try again";
public static final String SERVER_ERROR_SHUTDOWN = "The server is shutting
down";
+ public static final String ERROR_SELECT_CLUSTER_MODE = "SELECT is not
allowed in cluster mode";
Review comment:
I definitely understand what you mean. I think it would be good for us
to discuss this. There is also an `ERR DB index is out of range` message Redis
returns if the user tries to select a DB that is not 0-15, but is still a long.
We could potentially return that instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement Redis SELECT command
> ------------------------------
>
> Key: GEODE-8668
> URL: https://issues.apache.org/jira/browse/GEODE-8668
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Sarah Abbey
> Priority: Major
> Labels: pull-request-available
>
> We are implementing SELECT because some Redis analysis tools (like Redis
> Insight) require the SELECT command in order to function properly. Since
> Geode Redis is similar to Redis in cluster mode in that currently it only
> supports database zero, we emulated the behavior of SELECT in cluster mode.
> Only database zero may be selected. All other valid DB indices (from
> -9223372036854775807 to 9223372036854775807) return the same error as Redis
> in Cluster mode: ERR SELECT is not allowed in cluster mode. Any DB indices
> that cannot be parsed as a long will return the error: ERR invalid DB index
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
