[
https://issues.apache.org/jira/browse/GEODE-8643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221190#comment-17221190
]
ASF GitHub Bot commented on GEODE-8643:
---------------------------------------
albertogpz commented on a change in pull request #5653:
URL: https://github.com/apache/geode/pull/5653#discussion_r512451857
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -1393,7 +1393,11 @@ private boolean areAllTransactionsCompleteInBatch(Map
incompleteTransactions) {
return (incompleteTransactions.size() == 0);
}
- private long getTimeToSleep(long timeToWait) {
+ @VisibleForTesting
+ public static long getTimeToSleep(long timeToWait) {
Review comment:
Good points, thanks.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -1393,7 +1393,11 @@ private boolean areAllTransactionsCompleteInBatch(Map
incompleteTransactions) {
return (incompleteTransactions.size() == 0);
}
- private long getTimeToSleep(long timeToWait) {
+ @VisibleForTesting
+ public static long getTimeToSleep(long timeToWait) {
+ if (timeToWait < 0) {
Review comment:
Agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ParallelGatewaySenderQueue throws IllegalArgumentException for negative sleep
> value
> -----------------------------------------------------------------------------------
>
> Key: GEODE-8643
> URL: https://issues.apache.org/jira/browse/GEODE-8643
> Project: Geode
> Issue Type: Bug
> Components: wan
> Affects Versions: 1.14.0
> Reporter: Jens Deppe
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> While investigating GEODE-8642, I noticed this error in the logs:
> {noformat}
> [vm0] [info 2020/10/22 03:02:32.278 GMT <Recovery thread for bucket
> _B__aRegion_100> tid=0x8e] Initialization of region
> _B__index#__aRegion.files_100 completed
> [vm0] [info 2020/10/22 03:02:32.271 GMT <Recovery thread for bucket
> _B__aRegion_9> tid=0x70] Initialization of region
> _B__AsyncEventQueue__index#__aRegion__PARALLEL__GATEWAY__SENDER__QUEUE_9
> completed
> [vm0] [info 2020/10/22 03:02:32.278 GMT <Recovery thread for bucket
> _B__aRegion_58> tid=0x80] Initialization of region
> _B__index#__aRegion.files_58 completed
> [vm0] [info 2020/10/22 03:02:32.280 GMT <Recovery thread for bucket
> _B__aRegion_77> tid=0x86] Region
> /__PR/_B__AsyncEventQueue__index#__aRegion__PARALLEL__GATEWAY__SENDER__QUEUE_77
> recovered from the local disk. Old persistent ID:
> /172.17.0.10:/home/geode/geode/geode-lucene/build/upgradeTest5/LuceneSearchWithRollingUpgradeTestBase/diskStoreVM_0
> created at timestamp 1603335705530 version 0 diskStoreId
> 658975c5f23b479f-af5311e17567ca78 name null, new persistent ID
> /172.17.0.10:/home/geode/geode/geode-lucene/build/upgradeTest5/LuceneSearchWithRollingUpgradeTestBase/diskStoreVM_0
> created at timestamp 1603335751289 version 0 diskStoreId
> 658975c5f23b479f-af5311e17567ca78 name null
> [vm0] [warn 2020/10/22 03:02:32.277 GMT <Event Processor for
> GatewaySender_AsyncEventQueue_index#_aRegion_7> tid=0x62] An Exception
> occurred. The dispatcher will continue.
> [vm0] java.lang.IllegalArgumentException: timeout value is negative
> [vm0] at java.lang.Thread.sleep(Native Method)
> [vm0] at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.peek(ParallelGatewaySenderQueue.java:1310)
> [vm0] at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.processQueue(AbstractGatewaySenderEventProcessor.java:499)
> [vm0] at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1121)
> {noformat}
> I believe it may be related to this change:
> e4328553fb5783e8310833df42e1f17e48dc2ac4
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
