[
https://issues.apache.org/jira/browse/GEODE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220737#comment-17220737
]
ASF GitHub Bot commented on GEODE-5782:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5648:
URL: https://github.com/apache/geode/pull/5648#discussion_r512001303
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/LauncherMemberMXBeanIntegrationTest.java
##########
@@ -227,6 +227,8 @@ public void showJVMMetrics_returnsOJVMMetricsType()
if (cdsValue.equals(osMetricValue)) {
break;
}
+ System.gc();
+ System.runFinalization();
Review comment:
Yes, I'm probably on the wrong track here. The test flakiness is around
reporting memory stats. Since the underlying (volatile) values are retrieved
from `VMStatsMonitor` would it then be better to reduce the stat sampling
period so that values are updated more frequently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> LauncherMemberMXBeanIntegrationTest can fail intermittently
> -----------------------------------------------------------
>
> Key: GEODE-5782
> URL: https://issues.apache.org/jira/browse/GEODE-5782
> Project: Geode
> Issue Type: Test
> Components: jmx
> Affects Versions: 1.9.0
> Reporter: Jens Deppe
> Assignee: Jens Deppe
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Noticed this failure:
> {noformat}
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest >
> showOSMetrics_reconstructsOSMetricsFromCompositeDataType FAILED
> org.junit.ComparisonFailure: expected:<204.[68]> but was:<204.[55]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest.showOSMetrics_reconstructsOSMetricsFromCompositeDataType(LauncherMemberMXBeanIntegrationTest.java:143)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
