[ 
https://issues.apache.org/jira/browse/GEODE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219386#comment-17219386
 ] 

ASF GitHub Bot commented on GEODE-8645:
---------------------------------------

kohlmu-pivotal commented on a change in pull request #5655:
URL: https://github.com/apache/geode/pull/5655#discussion_r510525142



##########
File path: 
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubIntegrationTest.java
##########
@@ -20,6 +20,11 @@
 import org.apache.geode.redis.GeodeRedisServerRule;
 
 public class PubSubIntegrationTest extends AbstractPubSubIntegrationTest {
+
+  static {
+    System.setProperty("io.netty.eventLoopThreads", "10");
+  }
+

Review comment:
       Why could you not use `RestoreSystemProperties` here? 
   
   This test does not clean up itself after setting the property. What would 
the effect be if you don't clean up this property to the "default" value?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reduce netty threads used by PubSubIntegrationTest
> --------------------------------------------------
>
>                 Key: GEODE-8645
>                 URL: https://issues.apache.org/jira/browse/GEODE-8645
>             Project: Geode
>          Issue Type: Test
>          Components: redis, tests
>            Reporter: Jens Deppe
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to