[
https://issues.apache.org/jira/browse/GEODE-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218335#comment-17218335
]
ASF GitHub Bot commented on GEODE-8630:
---------------------------------------
sabbey37 commented on a change in pull request #5641:
URL: https://github.com/apache/geode/pull/5641#discussion_r509367538
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -142,6 +142,7 @@
RENAME(new RenameExecutor(), SUPPORTED, new ExactParameterRequirements(3)),
TTL(new TTLExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
TYPE(new TypeExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
+ UNLINK(new DelExecutor(), SUPPORTED, new MinimumParameterRequirements(2)),
Review comment:
We said it was `Unsupported` in the README, but added it as `Supported`
here. What did we ultimately decide?
##########
File path: geode-redis/README.md
##########
@@ -207,7 +207,7 @@ start server \
| | SUNION
| CLUSTER RESET |
| | SUNIONSTORE
| CLUSTER SAVECONFIG |
| | TIME
| CLUSTER SET-CONFIG-EPOCH |
-| |
| CLUSTER SETSLOT |
+| | UNLINK [1]
| CLUSTER SETSLOT |
Review comment:
We should update this docs file as well `redis_api_for_geode.html.md`.
It may also be good to ask John Martin to review these doc updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Redis UNLINK command
> ------------------------
>
> Key: GEODE-8630
> URL: https://issues.apache.org/jira/browse/GEODE-8630
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Implemented as a synonym to {{DEL}}. We are not doing async deletes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
