[
https://issues.apache.org/jira/browse/GEODE-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218001#comment-17218001
]
ASF GitHub Bot commented on GEODE-7671:
---------------------------------------
gesterzhou commented on a change in pull request #5512:
URL: https://github.com/apache/geode/pull/5512#discussion_r508900492
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/ClearGIIDUnitTest.java
##########
@@ -0,0 +1,507 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.apache.geode.cache.RegionShortcut.PARTITION;
+import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static
org.apache.geode.internal.cache.InitialImageOperation.getGIITestHookForCheckingPurpose;
+import static org.apache.geode.test.dunit.rules.ClusterStartupRule.getCache;
+import static
org.apache.geode.test.dunit.rules.ClusterStartupRule.getClientCache;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.Assert.fail;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.CountDownLatch;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheException;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionFactory;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.Index;
+import org.apache.geode.cache.query.IndexStatistics;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.distributed.internal.ClusterDistributionManager;
+import org.apache.geode.distributed.internal.DistributionMessage;
+import org.apache.geode.distributed.internal.DistributionMessageObserver;
+import org.apache.geode.test.awaitility.GeodeAwaitility;
+import org.apache.geode.test.dunit.Assert;
+import org.apache.geode.test.dunit.AsyncInvocation;
+import org.apache.geode.test.dunit.SerializableRunnable;
+import org.apache.geode.test.dunit.WaitCriterion;
+import org.apache.geode.test.dunit.rules.ClientVM;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+
+
+@RunWith(Parameterized.class)
+public class ClearGIIDUnitTest implements Serializable {
+
+
+ protected static final String REGION_NAME = "testPR";
+ protected static final String INDEX_NAME = "testIndex";
+ protected static final int TOTAL_BUCKET_NUM = 10;
+ protected static final int REDUNDANT_COPIES = 1;
+ protected static final int DATA_SIZE = 100;
+ protected static final int NUM_SERVERS = 2;
+
+ @Parameterized.Parameter(0)
+ public RegionShortcut regionShortcut;
+
+ protected int locatorPort;
+ protected MemberVM locator;
+ protected MemberVM[] serverVMs;
+ protected ClientVM client;
+
+ private static final Logger logger = LogManager.getLogger();
+
+ @Parameterized.Parameters
+ public static Collection<Object[]> getRegionShortcuts() {
+ List<Object[]> params = new ArrayList<>();
+ params.add(new Object[] {PARTITION});
+ params.add(new Object[] {REPLICATE});
+ return params;
+ }
+
+
+ @Rule
+ public ClusterStartupRule cluster = new ClusterStartupRule(4);
+
+ @Before
+ public void setUp() throws Exception {
+ locator = cluster.startLocatorVM(0);
+ locatorPort = locator.getPort();
+ }
+
+ private void initDataStore(RegionShortcut regionShortcut, boolean
isPartitioned) {
+ RegionFactory factory = getCache().createRegionFactory(regionShortcut);
+ if (isPartitioned) {
+ factory.setPartitionAttributes(
+ new PartitionAttributesFactory().setTotalNumBuckets(TOTAL_BUCKET_NUM)
+ .setRedundantCopies(REDUNDANT_COPIES)
+ .create());
+ }
+
+ factory.create(REGION_NAME);
+ }
+
+ private void startServers(int numberOfMembers) {
+ serverVMs = new MemberVM[numberOfMembers];
+ for (int i = 0; i < numberOfMembers; i++) {
+ serverVMs[i] = cluster.startServerVM(i + 1, locatorPort);
+ }
+
+ createAndPopulateRegion();
+ }
+
+ private void invokeClear(MemberVM datastore) {
+ datastore.invoke(() -> getCache().getRegion(REGION_NAME).clear());
+ }
+
+ private AsyncInvocation invokeClearAsync(MemberVM datastore) {
+ return datastore.invokeAsync(() ->
getCache().getRegion(REGION_NAME).clear());
+ }
+
+ private void createAndPopulateRegion() {
+ for (MemberVM datastore : serverVMs) {
+ datastore.invoke(() -> initDataStore(regionShortcut, isPartitioned()));
+ }
+
+ serverVMs[0].invoke(() -> {
+ Map<String, String> dataMap = new HashMap<String, String>();
+
+ for (int i = 0; i < DATA_SIZE; i++) {
+ dataMap.put("key" + i, String.valueOf(i));
+ }
+
+ getCache().getRegion(REGION_NAME).putAll(dataMap);
+
+ });
+ }
+
+ private void createDelta(int deltaSize) {
+ serverVMs[0].invoke(() -> {
+ Map<String, String> dataMap = new HashMap<String, String>();
+
+ for (int i = 0; i < deltaSize; i++) {
+ dataMap.put("key" + (i + DATA_SIZE), String.valueOf(i + DATA_SIZE));
+ }
+
+ getCache().getRegion(REGION_NAME).putAll(dataMap);
+
+ });
+ }
+
+ private boolean isPartitioned() {
+ if (regionShortcut == RegionShortcut.PARTITION
+ || regionShortcut == RegionShortcut.PARTITION_PERSISTENT) {
+ return true;
+ } else {
+ return false;
+ }
+ }
+
+ void restartServerOnVM(int index) {
+ cluster.startServerVM(index, locatorPort);
+ }
+
+ private void verifyRegionSize(int expectedNum) {
+ Region region = getCache().getRegion(REGION_NAME);
+ assertThat(region.size()).isEqualTo(expectedNum);
+ }
+
+ @Test
+ public void GIICompletesSuccessfullyWhenRunningDuringClear() {
+ startServers(NUM_SERVERS);
+ verifyRegionSizes(DATA_SIZE);
+
+ // set tesk hook
+ serverVMs[1].invoke(() -> {
+ PauseDuringGIICallback myAfterReceivedImageReply =
+ // using bucket name for region name to ensure callback is triggered
+ new PauseDuringGIICallback(
+ InitialImageOperation.GIITestHookType.AfterReceivedRequestImage,
"_B__testPR_9");
+ InitialImageOperation.setGIITestHook(myAfterReceivedImageReply);
+ });
+
+ cluster.stop(2);
+
+ createDelta(50);
+
+ restartServerOnVM(2);
+
+ AsyncInvocation async = createRegionAsync(serverVMs[1]);
+ invokeClear(serverVMs[0]);
+
+ serverVMs[1].invoke(() -> InitialImageOperation.resetGIITestHook(
+ InitialImageOperation.GIITestHookType.AfterReceivedRequestImage,
+ true));
+ try {
+ async.getResult(30000);
+ } catch (InterruptedException ex) {
+ Assert.fail("Async create interupted" + ex.getMessage());
+ }
+
+ verifyRegionSizes(0);
+ }
+
+ @Test
+ public void
GIICompletesSuccessfullyWhenRunningDuringClearWithThirdDatastore() {
+ startServers(NUM_SERVERS + 1);
+ verifyRegionSizes(DATA_SIZE);
+
+ // set tesk hook
+ serverVMs[1].invoke(() -> {
+ PauseDuringGIICallback myAfterReceivedImageReply =
+ // using bucket name for region name to ensure callback is triggered
+ new PauseDuringGIICallback(
+ InitialImageOperation.GIITestHookType.AfterReceivedRequestImage,
"_B__testPR_9");
+ InitialImageOperation.setGIITestHook(myAfterReceivedImageReply);
+ });
+
+ cluster.stop(2);
+
+ createDelta(50);
+
+ restartServerOnVM(2);
+
+ AsyncInvocation async = createRegionAsync(serverVMs[1]);
+ invokeClear(serverVMs[0]);
+
+ serverVMs[1].invoke(() -> InitialImageOperation.resetGIITestHook(
+ InitialImageOperation.GIITestHookType.AfterReceivedRequestImage,
+ true));
+ try {
+ async.getResult(30000);
+ } catch (InterruptedException ex) {
+ Assert.fail("Async create interupted" + ex.getMessage());
+ }
+
+ verifyRegionSizes(0);
+ }
+
+ @Test
+ public void
GIICompletesSuccessfullyWhenRunningDuringClearWithPersistentRegion() {
+ if (regionShortcut == RegionShortcut.PARTITION) {
+ regionShortcut = RegionShortcut.PARTITION_PERSISTENT;
+ } else if (regionShortcut == RegionShortcut.REPLICATE) {
+ regionShortcut = RegionShortcut.REPLICATE_PERSISTENT;
+ }
+ startServers(NUM_SERVERS);
+
+ verifyRegionSizes(DATA_SIZE);
+
+ // set tesk hook
+ serverVMs[1].invoke(() -> {
+ PauseDuringGIICallback myAfterReceivedImageReply =
+ // using bucket name for region name to ensure callback is triggered
+ new PauseDuringGIICallback(
+ InitialImageOperation.GIITestHookType.AfterReceivedRequestImage,
"_B__testPR_9");
+ InitialImageOperation.setGIITestHook(myAfterReceivedImageReply);
+ });
+
+ cluster.stop(2);
+
+ createDelta(50);
+
+ restartServerOnVM(2);
+
+ AsyncInvocation async = createRegionAsync(serverVMs[1]);
+ invokeClear(serverVMs[0]);
Review comment:
you need to add waitForCallbackStarted(serverVMs[1],
InitialImageOperation.GIITestHookType.AfterReceivedRequestImage);
before calling clear. This call will make sure the GII stopped at the
certain stage.
I added it for you and it failed. The reason is: you changed
receivedImageReply to be AfterReceivedRequestImage.
Only the provider will receive AfterReceivedRequestImage.
You need to do this for all of your test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Partitioned Region clear operations can occur successfully during GII
> ----------------------------------------------------------------------
>
> Key: GEODE-7671
> URL: https://issues.apache.org/jira/browse/GEODE-7671
> Project: Geode
> Issue Type: Sub-task
> Components: regions
> Reporter: Nabarun Nag
> Assignee: Benjamin P Ross
> Priority: Major
> Labels: GeodeCommons, pull-request-available
>
> Clear operations are successful when the region is undergoing GII
> Acceptance :
> * Passing DUnit tests where clear operations are successful on partitioned
> region when they are undergoing GII from another member
> * Test coverage to when a member departs in this scenario
> * Test coverage to when a member restarts in this scenario
> * Unit tests with complete code coverage for the newly written code.
>
> analyze if these tests are needed for offheap?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
