[
https://issues.apache.org/jira/browse/GEODE-8622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217934#comment-17217934
]
ASF GitHub Bot commented on GEODE-8622:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5636:
URL: https://github.com/apache/geode/pull/5636#discussion_r508837010
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/IncrByFloatExecutor.java
##########
@@ -46,15 +44,14 @@ public RedisResponse executeCommand(Command command,
byte[] incrArray = commandElems.get(INCREMENT_INDEX);
String doub = Coder.bytesToString(incrArray).toLowerCase();
if (doub.contains("inf") || doub.contains("nan")) {
Review comment:
Add a regex which should cover all options (I hope).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis INCRBYFLOAT should return an error message consistent with native Redis
> -----------------------------------------------------------------------------
>
> Key: GEODE-8622
> URL: https://issues.apache.org/jira/browse/GEODE-8622
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Geode Redis:
> {noformat}
> 127.0.0.1:6379> set anshin-1 weeble
> OK
> 127.0.0.1:6379> incrbyfloat anshin-1 2.0e2f
> (error) ERR Value at this key cannot be incremented numerically
> {noformat}
> Native Redis:
> {noformat}
> ERR value is not a valid float
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
