[
https://issues.apache.org/jira/browse/GEODE-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214311#comment-17214311
]
ASF GitHub Bot commented on GEODE-8602:
---------------------------------------
upthewaterspout merged pull request #5617:
URL: https://github.com/apache/geode/pull/5617
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted fails because
> test doesn't wait for view to have all members
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8602
> URL: https://issues.apache.org/jira/browse/GEODE-8602
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
> Affects Versions: 1.14.0
> Reporter: Bill Burcham
> Assignee: Dan Smith
> Priority: Major
> Fix For: 1.14.0
>
>
> {{MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}
> correctly waits for locators to start but then fails to wait for locators'
> views to be updated.
> This code:
> {code:java}
> assertThat(membership0.getView().getMembers()).hasSize(2);
> {code}
> …doesn't wait. This results in an exception sometimes:
> {code:java}
> org.apache.geode.distributed.internal.membership.gms.MembershipIntegrationTest
> > locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted FAILED
> java.lang.AssertionError:
> Expected size:<2> but was:<1> in:
> <[172.17.0.30(1:locator)<ec><v0>:41000]>
> at
> org.apache.geode.distributed.internal.membership.gms.MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted(MembershipIntegrationTest.java:308)
> {code}
> A Band-Aid would be to put an awaitility call around the two such hasSize()
> calls. A better fix would be to make the test deterministic per GEODE-8589.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
