[
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213456#comment-17213456
]
ASF GitHub Bot commented on GEODE-7845:
---------------------------------------
jinmeiliao commented on a change in pull request #5622:
URL: https://github.com/apache/geode/pull/5622#discussion_r504290220
##########
File path:
geode-core/src/upgradeTest/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradePartitionRegionClearServerVersionMismatch.java
##########
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.rollingupgrade;
+
+import static org.apache.geode.test.dunit.rules.ClusterStartupRule.getCache;
+import static
org.apache.geode.test.dunit.rules.ClusterStartupRule.getClientCache;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.assertj.core.api.Assertions.catchThrowable;
+
+import java.util.Collection;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.ServerVersionMismatchException;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientRegionFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.client.ServerOperationException;
+import org.apache.geode.distributed.internal.DistributionConfig;
+import org.apache.geode.test.dunit.IgnoredException;
+import org.apache.geode.test.dunit.rules.ClientVM;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+import org.apache.geode.test.version.VersionManager;
+
+/**
+ * This test class exists to test the ServerVersionMismatchException
+ * A ServerVersionMismatchException is thrown when a cluster has a server that
is previous to
+ * version 1.14.0 which doesn't support the Partitioned Region Clear feature.
+ *
+ * When the exception is thrown it is expected to contain the members that
have the bad version,
+ * the version number necessary, and the feature that is not supported.
+ */
+
+
+@RunWith(Parameterized.class)
[email protected](CategoryWithParameterizedRunnerFactory.class)
+public class RollingUpgradePartitionRegionClearServerVersionMismatch {
+
+ @Rule
+ public ClusterStartupRule cluster = new ClusterStartupRule();
+
+ @Parameterized.Parameter
+ public String oldVersion;
+
+ @Parameterized.Parameters(name = "from_v{0}")
+ public static Collection<String> data() {
+ List<String> result =
VersionManager.getInstance().getVersionsWithoutCurrent();
+ if (result.size() < 1) {
+ throw new RuntimeException("No older versions of Geode were found to
test against");
+ } else {
+ System.out.println("running against these versions: " + result);
+ }
+ return result;
+ }
+
+ // This is the message that we are expected to be in the exception in both
tests below.
+ private static final String expectedMessage =
+ "A server's [server-2] version was too old (< GEODE 1.14.0) for :
Partitioned Region Clear";
+
+ private MemberVM locator;
+ private MemberVM serverNew;
+
+ @Before
+ public void before() {
+ locator = cluster.startLocatorVM(0,
+ l ->
l.withSystemProperty("gemfire.allow_old_members_to_join_for_testing", "true")
+
.withProperty(DistributionConfig.ENABLE_CLUSTER_CONFIGURATION_NAME, "false"));
+ final int locatorPort = locator.getPort();
+
+ serverNew = cluster.startServerVM(1, locatorPort);
+ MemberVM serverOld =
+ cluster.startServerVM(2, oldVersion, s ->
s.withConnectionToLocator(locatorPort));
+
+ MemberVM.invokeInEveryMember(() -> {
+ Cache cache = getCache();
+ assertThat(cache).isNotNull();
+
getCache().createRegionFactory(RegionShortcut.PARTITION).create("regionA");
+ }, serverNew, serverOld);
+
+ // Put in some boiler plate data for region clear
+ serverNew.invoke(() -> {
+ Cache cache = getCache();
+ assertThat(cache).isNotNull();
+
+ Region<Object, Object> region = cache.getRegion("regionA");
+ region.put("A", "ValueA");
+ region.put("B", "ValueB");
+ });
+
+ }
+
+ /**
+ * testClient_ServerVersionMismatchException - validates that when a client
invokes a partitioned
+ * region clear on a cluster where one server is running an unsupported
version for this feature
+ * we return a ServerVersionMismatchException
+ */
+ @Test
+ public void testClient_ServerVersionMismatchException() throws Exception {
+ IgnoredException.addIgnoredException(ServerOperationException.class);
+ final int locatorPort = locator.getPort();
+ // Get a client VM
+ ClientVM clientVM = cluster.startClientVM(3, c ->
c.withLocatorConnection(locatorPort));
+
+ clientVM.invoke(() -> {
+ // Validate we have a cache and region
+ ClientCache clientCache = getClientCache();
+ assertThat(clientCache).isNotNull();
+
+ ClientRegionFactory<Object, Object> clientRegionFactory =
+ clientCache.createClientRegionFactory(ClientRegionShortcut.PROXY);
+ Region<Object, Object> region = clientRegionFactory.create("regionA");
+ assertThat(region).isNotNull();
+
+ // Validate that we get a ServerVersionMismatchException wrapped in a
ServerOperationException
+ Throwable thrown = catchThrowable(region::clear);
+ assertThat(thrown).isInstanceOf(ServerOperationException.class);
+
assertThat(thrown).hasCauseInstanceOf(ServerVersionMismatchException.class);
+
+ // Validate that the message is exactly as we expect it.
+ ServerVersionMismatchException serverVersionMismatchException =
+ (ServerVersionMismatchException) thrown.getCause();
+
assertThat(serverVersionMismatchException.getMessage()).isEqualTo(expectedMessage);
+ });
+ }
+
+ /**
+ * testServer_ServerVersionMismatchException - validates that when a
partitioned region clear is
+ * invoked on a cluster where one server is running an unsupported version
for this feature we
+ * return a ServerVersionMismatchException
+ */
+ @Test
+ public void testServer_ServerVersionMismatchException() {
+ IgnoredException.addIgnoredException(ServerOperationException.class);
Review comment:
every test will shut down all the locator/servers and restart them
again, making the tests taking longer. If you would like make the tests run
faster, you can lump these two tests into one. first all region.clear vm and
then in a server vm. And would be nice to verify that after these two clears,
the region still has those 2 records in them (clear didn't go through on any
servers).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rollingupgrade should not conflict with the new ClearPRMessage
> ---------------------------------------------------------------
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Xiaojian Zhou
> Assignee: Mark Hanson
> Priority: Major
> Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not
> fail. It should not be sent to the old members.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
