[
https://issues.apache.org/jira/browse/GEODE-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209805#comment-17209805
]
ASF GitHub Bot commented on GEODE-8517:
---------------------------------------
jchen21 commented on a change in pull request #5530:
URL: https://github.com/apache/geode/pull/5530#discussion_r501259365
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##########
@@ -754,8 +754,8 @@ protected void serializeKey(DataOutput out,
@Override
public void fromData(DataInput in,
DeserializationContext context) throws IOException,
ClassNotFoundException {
- fromDataPre_GEODE_1_13_0_0(in, context);
- if (version >= KnownVersion.GEODE_1_13_0.ordinal()) {
+ fromDataPre_GEODE_1_14_0_0(in, context);
+ if (version >= KnownVersion.GEODE_1_14_0.ordinal()) {
Review comment:
There is no need for condition check here. The appropriate version of
`fromData()` is invoked by `DSFIDSerializerImpl.invokeFromData()` and
`InternalDataSerializer.invokeFromData()`. For older versions, it will not
invoke `fromData()`. Instead, it will invoke `fromDataPre_GEODE_1_9_0_0` or
`fromDataPre_GEODE_1_14_0_0` depending on the version from `DataInput` or
`DeserializationContext`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> GatewaySenderEventImpl's 2 new attributes were introduced in 1.14 not 1.13
> --------------------------------------------------------------------------
>
> Key: GEODE-8517
> URL: https://issues.apache.org/jira/browse/GEODE-8517
> Project: Geode
> Issue Type: Bug
> Components: serialization
> Affects Versions: 1.14.0
> Reporter: Xiaojian Zhou
> Assignee: Xiaojian Zhou
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> GEODE-7971 introduced 2 new attributes isLastEventInTransaction and
> transactionId. At that time, the in-coming release was 1.13. So the
> GatewaySenderEventImpl specified GEODE_1_13_0 for the code changes. However,
> due to the release schedule change, the 2 attributes are actually introduced
> in 1.14. The 1.13 does not have them.
> So rollingUpgrade from 1.13 to 1.14 for PARALLEL_GATEWAY_SENDER_QUEUE region
> with GatewaySenderEventImpl will encounter serialization issue. This issue
> will only be triggered in TX use case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
