[
https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209798#comment-17209798
]
ASF GitHub Bot commented on GEODE-8512:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #661:
URL: https://github.com/apache/geode-native/pull/661#discussion_r501253554
##########
File path: cppcache/src/PdxType.cpp
##########
@@ -53,9 +54,13 @@ PdxType::PdxType(PdxTypeRegistry& pdxTypeRegistry,
m_isVarLenFieldAdded(false),
m_remoteToLocalFieldMap(nullptr),
m_localToRemoteFieldMap(nullptr),
- m_noJavaClass(false),
+ m_noJavaClass(!expectDomainClass),
Review comment:
Let's invert the member variable to be positive and reflect the usage.
So if it is the "expect domain class" member now let's rename it so.
##########
File path: cppcache/src/Cache.cpp
##########
@@ -153,7 +153,12 @@ LogLevel Cache::getLogLevel() { return Log::logLevel(); }
PdxInstanceFactory Cache::createPdxInstanceFactory(
const std::string& className) const {
- return m_cacheImpl->createPdxInstanceFactory(className);
+ return createPdxInstanceFactory(className, true);
Review comment:
Why does this default to `true`, wouldn't it have been implicitly
`false` perviously?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
> ----------------------------------------------------------------------------
>
> Key: GEODE-8512
> URL: https://issues.apache.org/jira/browse/GEODE-8512
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Minor
> Labels: JsonFormatter, pull-request-available
>
> Within Java client, you can specify if the PdxInstance you want to create is
> a Java domain class or not, but this is not the case for geode-native C++
> client.
> Thing is that in order to implement JsonFormatter in C++ client, having this
> change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON
> classname will present some issues while using cquery's.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
