[
https://issues.apache.org/jira/browse/GEODE-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209679#comment-17209679
]
ASF GitHub Bot commented on GEODE-8580:
---------------------------------------
mmartell opened a new pull request #670:
URL: https://github.com/apache/geode-native/pull/670
This is a fix to the new C++ test framework. We were throwing pointers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improper use of throw in new C++ test framework
> -----------------------------------------------
>
> Key: GEODE-8580
> URL: https://issues.apache.org/jira/browse/GEODE-8580
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Martell
> Assignee: Michael Martell
> Priority: Major
>
> The new C++ test framework (cppcache/integration/framework) throws pointers
> to exceptions. This is never a good idea.
> [https://stackoverflow.com/questions/10948316/throw-new-stdexception-vs-throw-stdexception]
> Although you can catch pointers, it's not recommended practice.
> Note: The particular error I ran into was in GfshExecute::execute, where
> throw new GfshExecuteException("gfsh error", exit_code);
> was being used. This requires gtest to use:
> EXPECT_THROW(gfsh.query(query_stmt).execute(), GfshExecuteException*);
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
