[
https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206567#comment-17206567
]
ASF GitHub Bot commented on GEODE-8571:
---------------------------------------
karensmolermiller commented on a change in pull request #666:
URL: https://github.com/apache/geode-native/pull/666#discussion_r499092657
##########
File path: cppcache/include/geode/internal/chrono/duration.hpp
##########
@@ -145,8 +145,8 @@ inline
/**
* Converts std::chrono::duration to std::string.
*
- * @tparam Rep
- * @tparam Period
+ * @tparam Rep the something that reps
+ * @tparam Period the something else that periods
Review comment:
Almost a worse definition than not having one at all?
##########
File path: cppcache/src/statistics/StatArchiveWriter.hpp
##########
@@ -232,9 +232,9 @@ class APACHE_GEODE_EXPORT StatArchiveWriter {
/**
* Opens the statArchiver by opening the file provided as a parameter.
- * @param std::string filename.
+ * @param filename string representation of the file
Review comment:
Better as
* @param filename string representation of the file name
##########
File path: cppcache/src/CqService.hpp
##########
@@ -211,8 +211,10 @@ class APACHE_GEODE_EXPORT CqService
* Invokes the CqListeners for the given CQs.
* @param cqs list of cqs with the cq operation from the Server.
* @param messageType base operation
- * @param key
- * @param value
+ * @param key to invoke listeners with
+ * @param value to invoke listeners with
+ * @param deltaValue to invoke listeners with
Review comment:
I don't see these parameters in the function header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce no documentation
> ------------------------
>
> Key: GEODE-8571
> URL: https://issues.apache.org/jira/browse/GEODE-8571
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
>
> Given I compile the code without exempting no-documentation
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
