[
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206512#comment-17206512
]
ASF GitHub Bot commented on GEODE-8566:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r499042866
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/key/AbstractExpireIntegrationTest.java
##########
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor.key;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import redis.clients.jedis.Jedis;
+
+import org.apache.geode.test.dunit.rules.RedisPortSupplier;
+
+public abstract class AbstractExpireIntegrationTest implements
RedisPortSupplier {
+
+ private Jedis jedis;
+ private static int REDIS_CLIENT_TIMEOUT = 10000000;
Review comment:
Good idea - since I'm touching a lot of these files already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis native tests should not also stand up a Geode server
> ----------------------------------------------------------
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and
> both classes have a {{@ClassRule}} that results in both a native (container)
> instance and a Geode instance starting up. Mostly not a problem except for
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
