[
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206266#comment-17206266
]
ASF GitHub Bot commented on GEODE-8553:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #660:
URL: https://github.com/apache/geode-native/pull/660#discussion_r498899089
##########
File path: cppcache/src/ThinClientLocatorHelper.cpp
##########
@@ -74,10 +74,15 @@ ThinClientLocatorHelper::ThinClientLocatorHelper(
m_sniProxyHost(sniProxyHost),
m_sniProxyPort(sniProxyPort) {
for (auto&& locatorAddress : locatorAddresses) {
- m_locHostPort.emplace_back(locatorAddress);
+ m_Locators.emplace_back(locatorAddress);
}
}
+std::vector<ServerLocation> ThinClientLocatorHelper::getLocators() const {
Review comment:
`const` is absolutely correct here and please keep adding more `const`.
I wish we could all agree to make C++ objects and methods `const` by default
and require keyword to make them mutable. Immutability for the win!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reduce ThinClientLocatorHelper lock time
> ----------------------------------------
>
> Key: GEODE-8553
> URL: https://issues.apache.org/jira/browse/GEODE-8553
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.12.0, 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> During my troublshootings, I've seen that locking m_locatorLock for the whole
> scope of the class function members might cause some inter-locks.
> Problem here and in many other places of the NC is that networking operations
> are performed while a mutex is locked. Therefore if *thread A* takes longer
> than expected in performing its network operation, it might block another one
> which does not requires any resource of the first *thread A*. Hence, the
> inter-lock.
> This improvement is the first one of a series regarding to lock scope
> reduction when it comes with code regarding networking in NC.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
