[
https://issues.apache.org/jira/browse/GEODE-8513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17204109#comment-17204109
]
ASF GitHub Bot commented on GEODE-8513:
---------------------------------------
metatype commented on pull request #5532:
URL: https://github.com/apache/geode/pull/5532#issuecomment-700817211
I don't have any concerns about removing the `doUnload`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> DeltaSesssionManager writes all sessions to disk on shutdown
> ------------------------------------------------------------
>
> Key: GEODE-8513
> URL: https://issues.apache.org/jira/browse/GEODE-8513
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> DeltaSesssionManager executes a query to fetch all sessions for the current
> context shutting down and then serializes them to disk. There is no need to
> do this since the sessions are persisted in the session region on the
> servers.
> This leads:
> * to unaccounted for disk usage.
> * execution of a potentially large query at shutdown.
> * class casting executions in antlr in some Tomcat instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
