[
https://issues.apache.org/jira/browse/GEODE-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202450#comment-17202450
]
ASF GitHub Bot commented on GEODE-8469:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r495290623
##########
File path: cppcache/src/ExceptionTypes.cpp
##########
@@ -30,8 +30,8 @@ namespace client {
void setThreadLocalExceptionMessage(std::string exMsg);
const std::string& getThreadLocalExceptionMessage();
-std::map<GfErrType,
- std::function<void(std::string, std::string&, GfErrType,
std::string)>>
+static std::map<GfErrType, std::function<void(std::string, std::string&,
+ GfErrType, std::string)>>
Review comment:
Can we make this conform to the naming convention.
Will be nice if some day this could be `constexpr`.
https://www.youtube.com/watch?v=INn3xa4pMfg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enforce no-missing-variable-declarations
> ----------------------------------------
>
> Key: GEODE-8469
> URL: https://issues.apache.org/jira/browse/GEODE-8469
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Given I compile the code without exempting no-missing-variable-declarations
> Then it should compile
> Note - was marked as a todo
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
