[
https://issues.apache.org/jira/browse/GEODE-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201768#comment-17201768
]
ASF GitHub Bot commented on GEODE-8533:
---------------------------------------
davebarnes97 opened a new pull request #5549:
URL: https://github.com/apache/geode/pull/5549
Questions for reviewers:
- Have the explanations satisfactorily stated that the compaction-threshold
is a percentage of live data (non-garbage), as opposed to a percentage of
garbage?
- Is it clear that the threshold is activated when the live data percentage
drops below the threshold, as opposed to exceeding it?
- Is the modified formula for calculating required disk space correct?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> User Guide - compaction-threshold mechanism descriptions are wrong
> ------------------------------------------------------------------
>
> Key: GEODE-8533
> URL: https://issues.apache.org/jira/browse/GEODE-8533
> Project: Geode
> Issue Type: Bug
> Components: docs
> Affects Versions: 1.13.0
> Reporter: Dave Barnes
> Assignee: Dave Barnes
> Priority: Major
>
> Zhengzhi Xu reports:
> The compaction threshold mechanism is misleading in current document.
> CompactionThreshold is percentage of remaining live data in the oplog at
> which an oplog is compactable, while current user document is described as
> percentage of garbage in the oplog like the below:
> --compaction-threshold: Percentage of garbage allowed in the file before it
> is eligible for compaction.
> The correct description is in the API document:
> {code:java}
> DiskStoreFactory setCompactionThreshold(int compactionThreshold) Sets the
> threshold at which an oplog will become compactable. Until it reaches this
> threshold the oplog will not be compacted. The threshold is a percentage in
> the range 0..100. When the amount of live data in an oplog becomes less than
> this percentage then when a compaction is done this garbage will be cleaned
> up freeing up disk space. Garbage is created by entry destroys, entry
> updates, and region destroys. Parameters: compactionThreshold - percentage of
> remaining live data in the oplog at which an oplog is compactable{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
