[
https://issues.apache.org/jira/browse/GEODE-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200290#comment-17200290
]
ASF GitHub Bot commented on GEODE-7584:
---------------------------------------
pdxcodemonkey commented on pull request #582:
URL: https://github.com/apache/geode-native/pull/582#issuecomment-696896376
Closing this PR, since it's clear I'm not going to get around to addressing
the changes requested any time soon, if at all. GEODE-7584 in Jira can remain
active as a low-priority issue indefinitely, I suppose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor PDX handling in ThinClientPoolDM
> -----------------------------------------
>
> Key: GEODE-7584
> URL: https://issues.apache.org/jira/browse/GEODE-7584
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> As a native client developer, I would very much like to fully understand
> what's going on in the PDX serialization/deserialization code.
> Unfortunately, much of this code is opaque and full of side-effect. For
> instance, ThinClientPoolDM::GetPDXIdForType first gets the type, which
> registers the type on the specific server the pool is talking to, then it
> broadcasts the type information to any/all other existing pools in the
> client. Cleaning up some of this stuff so you can see the discrete steps the
> code is executing will go a long way towards making it readable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
